Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move text-to-speech methods to a TTS singleton #4681

Open
CsloudX opened this issue Jun 17, 2022 · 6 comments
Open

Move text-to-speech methods to a TTS singleton #4681

CsloudX opened this issue Jun 17, 2022 · 6 comments
Milestone

Comments

@CsloudX
Copy link

CsloudX commented Jun 17, 2022

Describe the project you are working on

NO-GAM Application

Describe the problem or limitation you are having in your project

IMO, move tts methods to TTS class make more sence, like TIME class

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Before After
DisplayServer.tts_speak(String text) TTS.speak(String text)
DisplayServer.tts_stop() TTS.stop()
...

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

/

If this enhancement will not be used often, can it be worked around with a few lines of script?

Where was no problem but make things better.

Is there a reason why this should be core and not an add-on in the asset library?

Yes, it's core.

@Calinou
Copy link
Member

Calinou commented Jun 17, 2022

cc @bruvzg

@Calinou Calinou changed the title Move tts methods to TTS class Move text-to-speech methods to a TTS singleton Jun 17, 2022
@Calinou Calinou added this to the 4.0 milestone Jun 17, 2022
@ghost
Copy link

ghost commented Jun 17, 2022

cc @bruvzg

Will you please add stt(speech to text) also .

@Calinou
Copy link
Member

Calinou commented Jun 17, 2022

Will you please add stt(speech to text) also .

Speech to text is much more complex than text to speech, and it doesn't have a standard API exposed by the operating system. Therefore, it's outside the scope of a core feature and should be implemented by an add-on.

@ghost

This comment was marked as off-topic.

@Calinou
Copy link
Member

Calinou commented Jun 17, 2022

The Android sdk target should be updated we aren't able to target sdk 33. This is why we can't reach more device. Will you implement this please 😇😇

See godotengine/godot#48636.

PS: In the future, please don't derail other proposals with unrelated questions. This is your last warning.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 17, 2022

IMO making a new singleton for a few methods isn't worth it. But we could maybe move it to OS.

@aaronfranke aaronfranke modified the milestones: 4.0, 4.x Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants