Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project GUI Theme settings don't apply/inconsistent behavior #33902

Closed
hammeron-art opened this issue Nov 26, 2019 · 5 comments · Fixed by #81130
Closed

Project GUI Theme settings don't apply/inconsistent behavior #33902

hammeron-art opened this issue Nov 26, 2019 · 5 comments · Fixed by #81130

Comments

@hammeron-art
Copy link

hammeron-art commented Nov 26, 2019

Godot version:
3.2.beta.custom_build.(fa4f525)

OS/device including version:
Windows 10

Issue description:
I can set a custom default theme and font in Project Setting -> General -> GUI -> Theme. It affects the running game but it doesn't affect the nodes in the scene unless I restart the editor. Changes in the theme don't take effect immediately as well.

When I set a Control's theme directly, the changes update immediately. There should be no need to restart the editor to apply the default theme.

Also, the project's font always replaces the theme's even when it's null. For example, when the theme has a default font and there is no custom default font in the project settings, the theme's font is ignored.

Steps to reproduce:

  • Create a customized theme resource with a customized default font
  • Set a path to it in Project Setting -> General -> GUI -> Theme -> Custom
  • It takes no effect in the editor
  • Run the game
  • It takes effect in the game but the theme's font is ignored

Minimal reproduction project:
ProjectTheme.zip

@hammeron-art hammeron-art changed the title Project GUI Theme settings has no effect/inconsistent behavior Project GUI Theme settings don't apply/inconsistent behavior Nov 26, 2019
@KoBeWi
Copy link
Member

KoBeWi commented Nov 26, 2019

Related to #24067 and #33866

@kimjiy9607
Copy link

Screen Shot 2020-02-07 at 2 34 05 PM

Hi, I am trying to reproduce it but what do I from here? Theme -> Custom and do I hit close button? Thank you in advance!

@Calinou
Copy link
Member

Calinou commented Feb 7, 2020

@kimjiy9607 You need to load a theme file (.tres or .theme) by clicking the folder icon on the right of the "Custom" property.

@Calinou
Copy link
Member

Calinou commented May 20, 2020

Also, the project's font always replaces the theme's even when it's null. For example, when the theme has a default font and there is no custom default font in the project settings, the theme's font is ignored.

This is being tracked in #36614.

@Misignu
Copy link

Misignu commented Feb 23, 2021

+1 The default theme is applied when reloading the editor. But it messes up some dialog windows.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants