Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: GridMap is not included in SDFGI baking #40617

Closed
Tracked by #55327
Syntaxxor opened this issue Jul 23, 2020 · 4 comments
Closed
Tracked by #55327

Vulkan: GridMap is not included in SDFGI baking #40617

Syntaxxor opened this issue Jul 23, 2020 · 4 comments

Comments

@Syntaxxor
Copy link
Contributor

Syntaxxor commented Jul 23, 2020

Godot version:

4.0, master branch, Commit Hash: 0cd98ec

OS/device including version:

Windows 10 v. 2004, RTX 2060, NVidia GeForce Game-Ready Driver v. 451.67, Vulkan backend.

Issue description:
My Grid Map is not being shown in SDFGI, despite being set to be used for baked lighting. Mesh Instances are able to use SDFGI with the same settings, but if it's in a Grid Map, SDFGI doesn't work at all. The expected behavior would be the Grid Map producing the same sort of lighting as the Mesh Instances.
image

Steps to reproduce:
Create a Grid Map and place objects with it, and then enable SDFGI. If you construct the same thing with Mesh Instances, you will notice that they affect the lighting, but the Grid map doesn't.

Minimal reproduction project:

GridMapSDFGI.zip

@Calinou Calinou changed the title Grid Map not in SDFGI GridMap is not included in SDFGI baking Jul 23, 2020
@akien-mga akien-mga added this to the 4.0 milestone Jul 23, 2020
@Zylann
Copy link
Contributor

Zylann commented Jul 24, 2020

Does this mean all non-node-based mesh instances aren't included as well? (when using VisualServer only, that is) Or is it only a configuration issue?

@Syntaxxor
Copy link
Contributor Author

Does this mean all non-node-based mesh instances aren't included as well? (when using VisualServer only, that is) Or is it only a configuration issue?

@Zylann, I lack the knowledge of the Godot rendering pipeline to properly answer that question. However, I can confirm that SDFGI Baking does include MultiMeshInstance nodes and CSG nodes with or without a combiner.

@Calinou Calinou changed the title GridMap is not included in SDFGI baking Vulkan: GridMap is not included in SDFGI baking Nov 12, 2021
@clayjohn clayjohn modified the milestones: 4.0, 4.x Feb 23, 2023
@etodd
Copy link
Contributor

etodd commented Mar 22, 2023

This seems to be working for me. The lighting doesn't always update right away, but in general it works.

@Calinou
Copy link
Member

Calinou commented Mar 23, 2023

I can confirm SDFGI works with GridMap cells on 4.0.stable. The glowing cubes are GridMap cells, they both receive and contribute to GI:

image

Testing project: GridMapSDFGI2.zip

@Calinou Calinou closed this as completed Mar 23, 2023
@Calinou Calinou modified the milestones: 4.x, 4.0 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants