Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping an empty folder on HTML5 causes a Javascript error #46437

Closed
Nukiloco opened this issue Feb 26, 2021 · 4 comments
Closed

Dropping an empty folder on HTML5 causes a Javascript error #46437

Nukiloco opened this issue Feb 26, 2021 · 4 comments

Comments

@Nukiloco
Copy link

Godot version:

v3.2.3

OS/device including version:

Windows 10

Issue description:

When dropping an empty folder onto your game, on desktop this will normally return a file path from the files_dropped signal in the SceneTree. However when doing this on HTML5, you will be given a blank array and a javascript error with the error being "<generic error, no stack>" and the error number is 44.

Steps to reproduce:

  1. Connect a function to the files_dropped signal in the SceneTree.
  2. Run it on desktop, drop the project folder onto it, then drop an empty folder onto it. It will return the folder path on both of them.
  3. Run it on HTML5, drop the project folder onto it, then drop an empty folder onto it. It will return the folder path when it has files in it but when it has no files in it, it returns an empty array and a javascript error.

Minimal reproduction project:

FileDropHTML5Issue.zip

@akien-mga
Copy link
Member

I don't think file drag and drop is supported in 3.2.3, but it should be in 3.2.4 RC 3.

@Nukiloco
Copy link
Author

Nukiloco commented Feb 26, 2021

I tested it and drag and drop works on HTML5 on 3.2.3 for any file and folders as long as the folder isn't empty.

@akien-mga
Copy link
Member

Can you test 3.2.4 RC 3? There has been many changes for this platform.

@Faless
Copy link
Collaborator

Faless commented Apr 25, 2022

This seems fixed in current 3.x (likely by #55594).
Closing, feel free to drop a comment is you still experience it.

@Faless Faless closed this as completed Apr 25, 2022
@akien-mga akien-mga added this to the 3.5 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants