Undo keyboard shortcuts do not work reliably in 3D/2D scene or inspector

[elvisish]

Godot version

3.3.3 stable

System information

Windows 7 64-bit

Issue description

When attempting to undo or redo with keyboard shortcuts, Godot almost never works correctly in 3D scene or for inspector changes. It works fine in script or 2D, but breaks most of the time in 3D or when changing inspector values. Scene > Undo and Scene > Redo are for the most part fine, but shortcut keys break, until Scene > Undo or Scene > Redo is used, at which point it may work for a while.

Steps to reproduce

Create a spatial
Move it a few times
Undo/Redo keys will not work
Press Scene > Undo to get Undo/Redo keys working again
When you undo until past the point of creating the spatial, redo will break again
Press Scene > Redo to get Undo/Redo keys working again

Minimal reproduction project

I have tried and tried to create a minimal reproduction but it always starts working as soon as I delete a bunch of files, which leads me to believe it has something to do with certain content in a Godot project folder. Once I deleted a vast amount of files, Undo started working but redo still didn't work. It's completely unpredictable and I have no idea where to start diagnosing this issue, other than sending my entire game project to someone privately for analysis.

[Calinou]

Related to #53424.

[elvisish]

I've just tried doing the steps to reproduce on the latest 3.4 RC1 and it's just as bad, undo shortcuts are totally broken in a fresh scene if I create a spatial and move it.

[elvisish]

Related to #53424.

Yep, that's why I needed to make a fresh bug report as that one only focused on the inspector, whereas I think this is a greater problem involving the keyboard shortcuts everywhere outside of 2D and script editor. I'm hoping someone else will be able to chime in and offer some kind of emotional support for this as it's really hard to actually reproduce outside of the project I'm working on.

[elvisish]

Related: #53866

[elvisish]

Whoever's an expert with Godot's Undo/Redo, let me know and I'd be happy to share privately my project that has the problem. I've tried cutting it back but it just seems to make Undo/Redo work better the more files I remove. It's definitely broken and is causing me to lose a lot of work trying to diagnose the problem, which I can't do by myself unfortunately.

[elvisish]

Modifying this as my shortcut keys are broken in 2d mode too, on a reasonably fresh project when I just dragged a sprite into the scene. Undo/Redo menu works fine, shortcut keys totally broken.

[Calinou]

I've been able to reproduce this a handful of times on both 3.x 322ba88 and master c13319d, both in 2D and 3D editors. It seems to occur more often when using the AnimationPlayer editor, but this is just a guess.

Could you try to record a video while you're using the editor until this issue occurs, then edit the video to keep only the last 1-2 minutes and upload it here? This would likely help figure out definitive reproduction steps. Ideally, this should be done from a brand new project.

[SimplyPhy]

This can be easily reproduced on MacOS in the 3D editor in a new project on 4.0 Alpha 6. I noticed that sometimes simply opening and closing the file menu would allow cmd+z to work again (unreliable fix).

[elvisish]

I think part of the issue is which part of the dock windows are selected, clicking the background of the Scene tab or Inspector tab for instance seems to switch between the undo stacks which is... completely unorthodox.

[Calinou]

#59564 will likely fix this in 4.0, but it's unlikely to be backported to 3.x since it relies on compatibility-breaking UndoRedo changes.

[jayypluss]

May be related to #60005 and #28511

[elvisish]

Undo is still exactly as broken in 4.0 as in 3.x.

[Braveo]

I'm still currently having this issue in Godot 4 beta 10 (mono). Godot 3.5 has been much more forgiving with this issue as undoing and redoing has been for the most part consistent, but Godot 4 fails to undo and redo pretty much all the time when I use it, unless reload saved scene for some reason.

[adrianmg]

I'm having the same issue in Godot 3.5.1

CleanShot.2023-01-07.at.01.19.51.mp4

[reduz]

This should be in part fixed by #71328.
@adrianmg your video does not show a bug. Some controls have their own undo/redo stack (like code editor and line edit) that override the global undo/redo (which is now also per scene), so this is expected.
I feel in general this issue needs more information in order to have something actionable, else at this point it should probably be closed.

[elvisish]

This should be in part fixed by #71328. @adrianmg your video does not show a bug. Some controls have their own undo/redo stack (like code editor and line edit) that override the global undo/redo (which is now also per scene), so this is expected. I feel in general this issue needs more information in order to have something actionable, else at this point it should probably be closed.

Consistently in 3.x3, 3.4, 3.5 and 4.0 I've found that undo-ing is pretty flawless in the code editor (thank goodness) but requires manually clicking the File > Undo or File > Redo button to, I guess, activate the direction(?) of "do". For example, if you place some objects in the scene and press CTRL+Z, nothing might happen until you press File > Undo, then CTRL+Z will work continuously until you click in the scene editor. However, during Undo-ing with CTRL+Z, you might decide to Redo which won't work until File > Redo is clicked, then CTRL+Z will work every time until clicking somewhere else.

I've just gotten used to this way of working, it's very unpleasant but I'm just grateful the code editor never fails me (unless changing tab and trying to undo/redo, which can sometimes break).

[EricEzaM]

@elvisish sounds like you are talking about #66424, fixed by #71055

[EricEzaM]

Oh wait this issue just seems like a dupe of #66424 (or rather it was a dupe of this one) , I just read the OP. I think this can be closed.

[elvisish]

@elvisish sounds like you are talking about #66424, fixed by #71055

Is this for beta 11?

[EricEzaM]

Misclick... Mobile 💀

Yes it should be in b11 and later