Console no longer showing in windows builds

[clayjohn]

Godot version

master bd31af3

System information

Windows 10

Issue description

When building the engine in debug with the windows_subsystem=console build flag, the console no longer appears. This issue was introduced in the last week or two.

For clarity interface/editor/hide_console_window is false.

The console still appears in the project manager, but disappears when a project is opened.

Steps to reproduce

Build Godot using windows_subsystem=console and open a project in the engine.

Minimal reproduction project

No response

[ShlomiRex]

After investigating, it appears the build option is no longer exists in 3.4.
After digging, reading this:
#41332
It appears this feature was reverted and no longer exists.

[clayjohn]

#41332 added the windows_subsystem=console build command and reverted #41164 it did not remove the windows_subsystem=console command.

[akien-mga]

Probably caused by #54591, CC @WoLfulus @mhilbrunner.

[mhilbrunner]

I can confirm this was caused by #54591. Building the commit immediately before it (fa033e1) works as expected, whereas with it, the console closes as soon as the project manager exits to start the editor.

Starting the project manager from the console also doesn't work as a workaround, it still loses the streams once the manager exits and starts the editor.

Starting the editor directly (--editor) with the project from console, circumventing the project manager entirely, does work as a workaround.

[ShlomiRex]

May I ask what was the purpose of this command and why was it revoked?

[Chaosus]

Indeed, it's was caused by #54591 The correct action to fix it (I think) is somehow handling the content of its calling (probably through command-line arguments or global singletons) and don't attach the CREATE_NO_WINDOW flag if it's the editor or project manager.

[clayjohn]

@Chaosus That makes sense. In my local branch I have just removed CREATE_NO_WINDOW entirely.