Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer: "Editing imported animation" warning when "Save to File" is enabled #69595

Open
BenjaminNavarro opened this issue Dec 5, 2022 · 9 comments

Comments

@BenjaminNavarro
Copy link
Contributor

Godot version

4.0.dev (e1788b1)

System information

Linux, AMD Ryzen 9 5900HX, RTX 3080

Issue description

I'm porting my game to 4.0 and I have a GLTF model for the player with a bunch of animations.

I need to customize these animations in order to add custom tracks but even with the correct settings the editor still warns about the imported scene not being customizable.

It seems that the warning can be ignored since the animations point to the animation files and that adding custom tracks is possible and are kept between reimports.

Steps to reproduce

I tested with a GLTF model, I don't know if this affects other file formats as well.

  1. Select the model in the file system
  2. Go to the import tab and go to the advanced import options
  3. For each animation, enable "Save to File" and "Keep Custom Tracks" and set the path where to save it.
  4. Hit reimport
  5. Create an inherited scene from the model and open it
  6. Select the AnimationPlayer
  7. Animation Player has the "Imported Scene" warning telling to do what was already done in order to edit the animations

Minimal reproduction project

For testing I got a model + animation from Mixamo, converted it to GLTF using fbx2gltf and imported it in Godot.

We can see that the animation is actually saved to disk but it can't be customized using the AnimationEditor.

CustomAnimImportBug.zip

@Calinou
Copy link
Member

Calinou commented Dec 5, 2022

This warning was likely added by #63249.

cc @SaracenOne

@barrrettt
Copy link

same on beta11

@lyuma lyuma modified the milestones: 4.0, 4.1 Feb 22, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Same on stable

@SalgueiroAzul
Copy link

Hello, I'm having this problem as well on 4.0.2.
I'm trying to change the interpolation of my animations, but getting this warning as well, even with the correct import settings.
Anyone managed to find a work around?

@ghost
Copy link

ghost commented May 12, 2023

Hello, I'm having this problem as well on 4.0.2. I'm trying to change the interpolation of my animations, but getting this warning as well, even with the correct import settings. Anyone managed to find a work around?

Verify if it works or not.
I had the warning but was able to modify my animation anyway and everything worked fine.

@SalgueiroAzul
Copy link

SalgueiroAzul commented May 12, 2023

Hello, I'm having this problem as well on 4.0.2. I'm trying to change the interpolation of my animations, but getting this warning as well, even with the correct import settings. Anyone managed to find a work around?

Verify if it works or not. I had the warning but was able to modify my animation anyway and everything worked fine.

Thank for your reply. I was indeed able to modify the animations, but it tends to revert back the changes very easily.

If I close the project for example, I have to change the interpolation again every time I open it... And sometimes it'll happen randomly.

Edit: It seems that adding any kind of custom track to the animation fixes the reseting!

@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 23, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Nov 14, 2023
@BeerHuntor
Copy link

Still getting this issue. Still hasn't been fixed

@Mohammadreza-Beygifard
Copy link

I am getting this issue and it is not fixed! v4.4 dev7 MacOS

@DangerousWhenWet
Copy link

In v4.3.stable.official [77dcf97] I also have the [⚠️ Imported Scene] warning after importing a *.glb and adding it to an inherited scene.
I followed its message's instructions to try and make it go away:

This animation belongs to an imported scene, so changes to imported tracks will not be saved.

To modify this animation, navigate to the scene's Advanced Import settings and select the animation.
Some options, including looping, are available here. To add custom tracks, enable "Save To File" and
"Keep Custom Tracks".

by which I mean I enabled "Save to File" and "Keep Custom Tracks" as well as set save path for all my animations, then re-imported. I still have the [⚠️ Imported Scene] warning but can in fact edit the animations anyway and save the changes, and they are persisted even when I e.g. reload Godot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Assess
Development

No branches or pull requests

9 participants