Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing space when entering the name of an editor layout confirm the save dialog #81161

Closed
mieldepoche opened this issue Aug 30, 2023 · 2 comments · Fixed by #81189
Closed

Comments

@mieldepoche
Copy link
Contributor

mieldepoche commented Aug 30, 2023

Godot version

4.1.1

System information

linux

Issue description

simplescreenrecorder-2023-08-30_15.01.51.webm

I guess this wasn't the case before since I could save a layout named "2 monitors".

Steps to reproduce

press space

Minimal reproduction project

none

@jsjtxietian
Copy link
Contributor

jsjtxietian commented Aug 31, 2023

Related to #77297
Before it the _line_gui_input only accepts Enter and Escape, but now it utilizes key mapping ui_accept which contains Space key as well.

image

This is a LineEdit class for user to type in some string, maybe we do not need to use ui_accept here ? @puchik Any thoughts?

@puchik
Copy link
Contributor

puchik commented Aug 31, 2023

Kind of a weird one because it's obviously not great behaviour but it's still not optimal to hardcode the enter key and/or break consistency.

Maybe the best solution is to leave the ui_accept as its mapping but exclude the space key (i.e., "if ui_accept and not Space").

The only downside to that is it'll break if ui_accept is only Space, but that's kind of an unusual decision 😛 I think "hijacking" the space bar input in this use case makes sense

@YuriSizov YuriSizov added this to the 4.2 milestone Aug 31, 2023
@akien-mga akien-mga changed the title pressing space when entering the name of an editor layout confirm the save dialog Pressing space when entering the name of an editor layout confirm the save dialog Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants