Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Shaders are always updating but not in 2D #82309

Open
DarkRewar opened this issue Sep 25, 2023 · 2 comments
Open

3D Shaders are always updating but not in 2D #82309

DarkRewar opened this issue Sep 25, 2023 · 2 comments

Comments

@DarkRewar
Copy link

Godot version

v4.1.1.stable.mono.official [bd6af8e]

System information

Godot v4.1.1.stable.mono - macOS 13.5.2 - Vulkan (Forward+) - integrated Apple M2 Pro - Apple M2 Pro (12 Threads)

Issue description

Shaders that have UV scrolling by time are always refreshing in 3D editor scene, but not in 2D editor scene.

Side note: I can also reproduce the bug on my Windows 10 I7-7700k 970 GTX 16Go RAM.

Steps to reproduce

You can create a simple visual shader with those nodes :

image

What it happens in 2D view, the material doesn't scroll, even if I move in the scene :

bug_scroll_2D

What it happens in 3D view, the material is always scrolling :

bug_scroll_3D

Actually, I don't know which behaviour is really intended. Due to performance lacks, I think the shader shouldn't update in the 3D view, or at least allow the view to refresh or not (like a "Always refresh" toggle option from the scene context top-left menu).

Minimal reproduction project

Project to reproduce the bug : GodotScrollShaderBug.zip

@Calinou
Copy link
Member

Calinou commented Sep 25, 2023

I think the shader shouldn't update in the 3D view, or at least allow the view to refresh or not (like a "Always refresh" toggle option from the scene context top-left menu).

See #76734.

@sdrib
Copy link

sdrib commented Sep 26, 2023

Is this not also related, in part, to 2D having repeat_enabled as false and 3D having repeat_enabled as true mentioned here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants