Select tool translates node when dragging w/o the gizmo over geometry

[ryevdokimov]

Tested versions

v4.2.1.stable.mono.official [b09f793]
v4.3.dev.custom_build [b4e2a24]

System information

Godot v4.2.1.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.24002.92) - AMD Ryzen 7 PRO 6850U with Radeon Graphics (16 Threads)

Issue description

When attempting to region-select over geometry while a node is selected, and the select tool is enabled, the selected node ends up being translated, which seems wrong.

2024-02-03.23-23-48.mp4

Steps to reproduce

See video.

Select node using select tool.

Attempt to region select over some kind other geometry like another mesh.

Minimal reproduction project (MRP)

N/A

[KoBeWi]

I can't reproduce it. Select Mode will always select.
Tested on master.

[ryevdokimov]

I also just tested on master and can reproduce on that build as well. To be clear, you are holding down the mouse starting on-top of some geometry like a mesh, and then dragging as if you're doing a region select?

[AThousandShips]

This is specific to region select, which isn't specified in the issue report

Note that this was done by design as far as I can tell, or simply from the comment, so this shouldn't be considered a bug IMO, and we need to look at the consequences of this change

[KoBeWi]

Ah I see it now. There are 2 object involved and the selected one is being moved when you drag a different object. This is definitely a bug, dragging should only happen on the selected object.

[ryevdokimov]

Fair point. I updated the reproduction instructions. I did a git blame to trace some of the PRs involved with this back and I couldn't find any explanation that this was by design.

[AThousandShips]

I mean the comment saying it implies design, and it was approved as such, see:

• Improved region-select in the 3D editor viewport #57847

[KoBeWi]

The PR linked shows a different issue.

[ryevdokimov]

I mean the comment saying it implies design, and it was approved as such, see:

• Improved region-select in the 3D editor viewport #57847

Yes, I saw that PR, but I don't see an explanation that translating the node in place of region select is the intended design.

[AThousandShips]

Yes but it's the origin of this, at least we need to ensure the issues in that PR doesn't resurface

But I fail to see how "select only if nothing is selected" isn't clear intention

[ryevdokimov]

Fair point again, but it also isn't true and isn't described in the PR itself only in the comment of the code itself which can be overlooked. In both 4.2 and master, you can region select while nodes are selected, but only outside geometry. This isn't explained anywhere, and also doesn't really make any sense IMO.

[AThousandShips]

Oh thank you for specifying that part 🙂 it got lost in the very long title (of the PR) 😄

[ryevdokimov]

Triple fair point, I'll do better in my explanations from the get-go. Sometimes I just get caught up in writing code.

[AThousandShips]

Oh it's natural, I should have read more carefully, but good to add in the description of the PR, especially with very long titles it's easier to get the info from the text

Keep also in mind that it can be hard to tell from a video what behaviour is the issue, it's easy to think "oh this is clear" when you know what's wrong already, so important to capture the issue in text too

[ryevdokimov]

Titles too long, descriptions too short got it. 😂

[Cammymoop]

This is a duplicate of #85736