Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key input events in Input Map behave strangely after cancelling an edit #90833

Closed
emanresU102396 opened this issue Apr 18, 2024 · 1 comment · Fixed by #90835
Closed

Key input events in Input Map behave strangely after cancelling an edit #90833

emanresU102396 opened this issue Apr 18, 2024 · 1 comment · Fixed by #90835

Comments

@emanresU102396
Copy link

Tested versions

v4.2.1.stable.official [b09f793]

System information

Godot v4.2.1.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4080 Laptop GPU (NVIDIA; 31.0.15.4633) - AMD Ryzen 9 7940HS w/ Radeon 780M Graphics (16 Threads)

Issue description

A key input event under an action changes into a keycode event that's incorrectly labeled after canceling an edit and editing it again or editing a different event/action.

image

Steps to reproduce

  1. Add a keyboard input event to an Input Map action in Project Settings. (Any key event is fine, as long as it's one that has a corresponding keycode.)
  2. Click the button to edit the event, then click Cancel.
  3. Edit the event again (without changing anything) and click OK. (Or edit any other event, or add a new event, or add a new action, or delete an event, or delete an action...)
  4. Observe that the event now says "[key] or [key] (Physical) or [key] (Unicode)", and uses a keycode (even if it previously used a physical key or key label).

Minimal reproduction project (MRP)

N/A

@jsjtxietian
Copy link
Contributor

Looks like a regression of #77900

That pr will set the missing keycode, so it changed the origin event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants