Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSAO renders reversed in orthographic Camera3D #94139

Closed
mertkasar opened this issue Jul 9, 2024 · 2 comments · Fixed by #94153
Closed

SSAO renders reversed in orthographic Camera3D #94139

mertkasar opened this issue Jul 9, 2024 · 2 comments · Fixed by #94153
Labels
bug confirmed regression topic:rendering topic:3d
Milestone
4.3

Comments

@mertkasar
Copy link
Contributor

Tested versions

  • Reproducible in: v4.3.beta2.official [b75f048], v4.3.beta1.official [a4f2ea9], v4.3.dev6.official [89850d5]
  • Not reproducible in: earlier v4.x.x snapshots

System information

Godot v4.3.dev6 - Ubuntu 24.04 LTS 24.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 535.183.01) - AMD Ryzen 9 7950X 16-Core Processor (32 Threads)

Issue description

SSAO renders reversed in Camera3D set in orthographic projection. Looks like the issue was introduced in v4.3.dev6.official [89850d5] Earlier versions work correctly.

ssao_on

Steps to reproduce

You can toggle the camera preview in the editor or play the main scene.

Minimal reproduction project (MRP)

ssao_orthographic_mrp.zip
@akien-mga akien-mga added this to the 4.3 milestone Jul 9, 2024
@akien-mga
Copy link
Member

@godotengine/rendering Probably another reverse Z victim?

@akien-mga akien-mga moved this from Unassessed to Release Blocker in 4.x Release Blockers Jul 9, 2024
@clayjohn
Copy link
Member

clayjohn commented Jul 9, 2024

@godotengine/rendering Probably another reverse Z victim?

Yep. Most likely. Should be an easy fix in that case

@github-project-automation github-project-automation bot moved this to For team assessment in Rendering Issue Triage Jul 9, 2024
@clayjohn clayjohn moved this from For team assessment to Up for grabs in Rendering Issue Triage Jul 9, 2024
@clayjohn clayjohn mentioned this issue Jul 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from Up for grabs to Done in Rendering Issue Triage Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression topic:rendering topic:3d
Projects
4.x Release Blockers
Status: Release Blocker
Rendering Issue Triage
Status: Done
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Properly linearize depth buffer for SSAO when using orthogonal camera clayjohn/godot
4 participants
@Calinou @mertkasar @akien-mga @clayjohn