Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting signal does not generate their method in C# script #95703

Closed
tvardero opened this issue Aug 17, 2024 · 4 comments
Closed

Connecting signal does not generate their method in C# script #95703

tvardero opened this issue Aug 17, 2024 · 4 comments

Comments

@tvardero
Copy link

tvardero commented Aug 17, 2024

Tested versions

v4.2.2.stable.mono.official [15073af]

System information

Windows 11 Pro

Issue description

External editor: Jetbrains Rider.
.Net installed:

> dotnet --list-runtimes
Microsoft.AspNetCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.32 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.32 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

> dotnet --list-sdks
8.0.301 [C:\Program Files\dotnet\sdk]

Connecting node signal to a non-yet-existing method does not create the method in C# scene script.

Might be related: #18721

Steps to reproduce

  1. Create a scene of any node type;
  2. Add C# script;
  3. Add any child node that can produce a signal (for example Area2D);
  4. Save .tscn and .cs files;
  5. Select any signal and try to connect it.

Expected: method is created in C# class, signal is connected in .tscn file to that method.
Actual: method is not generated, however signal is now connected to non-existing method in .tscn file.

Minimal reproduction project (MRP)

Connecting signal issue.zip

@tvardero
Copy link
Author

2024-08-17-20-01-15.mp4

@tvardero
Copy link
Author

tvardero commented Aug 17, 2024

Ah, found this one: #87952 . That explains it.

However, need to note that warning was not displayed, neither in my project, nor in MRP project.
(the warning that "C# callback will not be generated and I need to write it myself")

@raulsntos
Copy link
Member

That warning was added in 4.3, but you are using 4.2.2 and the PR hasn't been cherry-picked yet.

@AThousandShips
Copy link
Member

Thank you for reporting, closing and consolidating in:

Should be cherry picked to a future 4.2.x version, or you can use 4.3

@AThousandShips AThousandShips closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants