From e5bebbc9ffda8b4fa5a786842ea24f0a3ea0763a Mon Sep 17 00:00:00 2001 From: Rindbee Date: Sat, 20 May 2023 22:58:14 +0800 Subject: [PATCH] Fix unnecessary break when calculating the height of visible lines This break causes the minsize to be smaller than expected, and then the size keeps increasing by one line to cover all visible lines. This can cause performance issues when there are many visible lines. --- scene/gui/label.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/scene/gui/label.cpp b/scene/gui/label.cpp index a9f704e904df..7b78477cbc37 100644 --- a/scene/gui/label.cpp +++ b/scene/gui/label.cpp @@ -290,9 +290,6 @@ void Label::_update_visible() { int last_line = MIN(lines_rid.size(), lines_visible + lines_skipped); for (int64_t i = lines_skipped; i < last_line; i++) { minsize.height += TS->shaped_text_get_size(lines_rid[i]).y + line_spacing; - if (minsize.height > (get_size().height - style->get_minimum_size().height + line_spacing)) { - break; - } } }