🤗 Custom response ?

[s1ntaxe770r]

Question description
im trying to return a custom response when a user completes an upload but i seems to be missing something because its not working , neither of the response seem to be working.

Code snippet Optional

package handlers

import (
	"fmt"
	"log"
	"github.com/gofiber/fiber"
)

func Upload() fiber.Handler {
	return func(c *fiber.Ctx) {
		file, err := c.FormFile("file")
		if err != nil {
			log.Printf("err from logger:>  %s", err)
			c.Send(fiber.Map{
				"message": err,
			})
		}
		c.SaveFile(file, fmt.Sprintf("./%s", file.Filename))
		c.Send(fiber.Map{
			"status": "success",
		})

	}
}

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[Fenny]

Also make sure that your BodyLimit is set to the max size you want to upload, it defaults to 4MB (4 * 1024 * 1024)

app := fiber.New(&fiber.Settings{
    BodyLimit: 12 * 1024 * 1024, // 12 MB
})

func Upload() fiber.Handler {
	return func(c *fiber.Ctx) {
		file, err := c.FormFile("file")
		if err != nil {
			log.Printf("err from logger:>  %s", err)
			c.JSON(fiber.Map{
				"message": err,
			})
		}
		// Pass error to errorhandler
		if err := c.SaveFile(file, fmt.Sprintf("./%s", file.Filename)); err != nil {
			c.Next(err)
			return
		}
		// Format JSON
		c.JSON(fiber.Map{
			"status": "success",
		})

	}
}

[s1ntaxe770r]

Thank you so much it works now. Why do you have to return after c.Next(err)

[Fenny]

Else it would continue to modify the response, when you return from the handler it will flush the response to the client.
In the upcoming version v1.15.x it requires you to return an error.

// v1.14.5
func Upload() fiber.Handler {
	return func(c *fiber.Ctx) {
		file, err := c.FormFile("file")
		if err != nil {
			log.Printf("err from logger:>  %s", err)
			c.JSON(fiber.Map{
				"message": err,
			})
		}
		if err := c.SaveFile(file, fmt.Sprintf("./%s", file.Filename)); err != nil {
			c.Next(err)
			return
		}
		c.JSON(fiber.Map{
			"status": "success",
		})
	}
}
}
// v1.15.0 ( 15 September 2020 )
func Upload() fiber.Handler {
	return func(c *fiber.Ctx) error {
		file, err := c.FormFile("file")
		if err != nil {
			return err // calls global error handler
		}
		if err := c.SaveFile(file, fmt.Sprintf("./%s", file.Filename)); err != nil {
			return err // calls global error handler
		}
		return c.JSON(fiber.Map{"status": "success"})
	}
}