Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecatation info messages not printed to console #13265

Closed
jmooring opened this issue Jan 15, 2025 · 5 comments
Closed

Deprecatation info messages not printed to console #13265

jmooring opened this issue Jan 15, 2025 · 5 comments
Assignees
Labels
Milestone

Comments

@jmooring
Copy link
Member

I'm pretty sure that I'm testing this correctly.

This:

hugo.Deprecate("site config key privacy.twitter.disable", "Use privacy.x.disable instead.", "v0.140.0")

Is not printing anything with hugo --logLevel info.

If I do this:

hugo.Deprecate("site config key privacy.twitter.simple", "Use privacy.x.simple instead.", "v0.135.0")

Warnings are displayed in the console.

I know we made some recent changes to messages that used to print to stdout.

@jmooring jmooring changed the title Deprecate info messages not printed to console Deprecatation info messages not printed to console Jan 15, 2025
@bep bep self-assigned this Jan 15, 2025
@bep bep added this to the v0.141.0 milestone Jan 15, 2025
@bep bep removed the NeedsTriage label Jan 15, 2025
@bep
Copy link
Member

bep commented Jan 15, 2025

I'm pretty sure that I'm testing this correctly.

I just tested this and it seems to work fine for me ...

image

@jmooring
Copy link
Member Author

I would be surprised if there were a difference between mac and linux. Not sure why I'm not seeing the info messages but the warning appear just fine. I'll attribute this to solar flares and move on.

@bep bep reopened this Jan 15, 2025
@bep
Copy link
Member

bep commented Jan 15, 2025

Control question. Where are you logging this? The config loading? If so, I will do another check, because I know that we create a "temporary global logger" before the config is set, and possibly the log level is off in this one.

@bep
Copy link
Member

bep commented Jan 15, 2025

The config loading?

Yea, that seems to be it.

@jmooring
Copy link
Member Author

The config loading?

Yes.

@bep bep closed this as completed in 4113707 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants