Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'quit' command doesn't immediately quit #139

Closed
jocap opened this issue Feb 18, 2019 · 8 comments
Closed

'quit' command doesn't immediately quit #139

jocap opened this issue Feb 18, 2019 · 8 comments
Labels

Comments

@jocap
Copy link

jocap commented Feb 18, 2019

OS: OpenBSD 6.4
Release: r10

When I type 'q', I expect lf to quit immediately. What happens instead is nothing. I have to press another key to get lf to quit -- sometimes even two or three.

That is, 'q' alone doesn't quit. 'qq' sometimes quits. 'qqw' sometimes quits.

Any ideas?

@gokcehan
Copy link
Owner

@jocap There are currently two more bugs reported in OpenBSD, #110 and #115, which may be related to this. It seems that OpenBSD has been making breaking changes lately. It would be nice if we have someone to asses the current situation in OpenBSD, by manually compiling from the source with Go1.11+ and the latest termbox-go version. If not, I will try to set up an OpenBSD virtual machine at some point though it can take some time and I'm not familiar with BSDs.

@gokcehan gokcehan added the bug label Feb 19, 2019
@jocap
Copy link
Author

jocap commented Feb 19, 2019 via email

@gokcehan
Copy link
Owner

@jocap Thanks for helping out for this. Can you confirm you have Go1.11 installed? Also can you try one of the demo programs that comes with termbox-go to see if the problem is termbox related or not?

go run ~/go/src/github.com/nsf/termbox-go/_demos/keyboard.go
# or other demos in this directory

@jocap
Copy link
Author

jocap commented Feb 20, 2019 via email

@gokcehan
Copy link
Owner

@jocap So I have set up an OpenBSD virtual machine to see it for myself. As I mentioned in the other issue, it seems that OpenBSD workaround commit pushed on Jan 4 made this problem much less severe than before. I guess there are some people that are aware of this and they are working on to fix it though I have not found a related issue in termbox-go to track this.

@jocap
Copy link
Author

jocap commented Feb 21, 2019 via email

@gokcehan
Copy link
Owner

We have already changed from termbox to tcell which is available in r17 and this issue is likely fixed. Closing this issue now. Feel free to leave further comments here if the issue persists.

@Limero
Copy link
Contributor

Limero commented Feb 8, 2023

I installed OpenBSD 7.2 and lf from the official repos (pkg_add lf) and had this issue. They still seem to ship r22.

After manually building latest master from git (r28), I can confirm that this is no longer an issue and lf seems to work the same as on Linux 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants