-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: keep SocketConn or not? #11492
Comments
I'm having a hard time understanding its docs:
@mikioh, what does this enable users to do? /cc @ianlancetaylor |
I intend to write a more complete comment on the CL but I have been preempted by other work. As I understand it, SocketConn is FileConn but allows the use of arbitrary socket address types instead of just the few that FileConn knows about. It seems to me that the net package should just keep using (and providing) only FileConn but perhaps we can put a registration mechanism in package syscall to let clients register converters between sockaddrs and net.Addr for non-standard sockaddr types. |
Thanks for the explanation, @rsc. Simply I wanted to allow us to mix features under the hood, various hardware-offloading stuff, new extensions for transport protocols and routing metrics for transport path selection, in existing network applications. For that purpose I needed to find out some way injecting unknown socket address and endpoint types in the standard library into runtime-integrated network poller.
If it does make sense and is possible, I'm happy to revert the current change and will take the approach in Go 1.6. |
Yes, I'd prefer it be reverted for now too and we can give it more thought for Go 1.6. |
CL https://golang.org/cl/11854 mentions this issue. |
See CL https://go-review.googlesource.com/#/c/9275/.
Is this really necessary? I suspect not.
The text was updated successfully, but these errors were encountered: