Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.8: merge CL 36417 to Go 1.8 branch #18969

Closed
ianlancetaylor opened this issue Feb 6, 2017 · 9 comments
Closed

go1.8: merge CL 36417 to Go 1.8 branch #18969

ianlancetaylor opened this issue Feb 6, 2017 · 9 comments
Milestone

Comments

@ianlancetaylor
Copy link
Member

We need to merge CL 36417 to the Go 1.8 branch for #18968.

CC @crawshaw @bradfitz @broady

@ianlancetaylor ianlancetaylor added this to the Go1.8 milestone Feb 6, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Feb 6, 2017

(ab067cd)

@odeke-em
Copy link
Member

odeke-em commented Feb 6, 2017

Since I didn't want to open a new issue for this one
CL 36470 and commit 3b68a64

Perhaps we can repurpose this bug to track CLs that we need to merge for Go1.8?

@odeke-em
Copy link
Member

odeke-em commented Feb 6, 2017

/cc @griesemer who fixed it.

@broady
Copy link
Contributor

broady commented Feb 6, 2017

I think it's fine to open a new issue for anything that needs merging for 1.8. There shouldn't be many (if any at all).

Closing this (tracked in #18915).

@broady broady closed this as completed Feb 6, 2017
@ianlancetaylor
Copy link
Member Author

@broady Did you mean to close this issue? This one was about CL 36417. Reopening.

@ianlancetaylor ianlancetaylor reopened this Feb 7, 2017
@broady
Copy link
Contributor

broady commented Feb 7, 2017

@ianlancetaylor Nope, I'm just confused. @odeke-em can you open a separate issue for CL 36470?

@rsc
Copy link
Contributor

rsc commented Feb 7, 2017

https://go-review.googlesource.com/36421 for this issue.

@rsc
Copy link
Contributor

rsc commented Feb 7, 2017

https://go-review.googlesource.com/36422 for CL 36470.

@odeke-em
Copy link
Member

odeke-em commented Feb 7, 2017

Thanks @broady @rsc @griesemer, no need for me to file the issue,
it's already been handled as @rsc mentioned.

@rsc rsc closed this as completed Feb 7, 2017
@golang golang locked and limited conversation to collaborators Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants