Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis: migrate golint to use go/analysis #36869

Closed
stamblerre opened this issue Jan 29, 2020 · 5 comments
Closed

x/tools/go/analysis: migrate golint to use go/analysis #36869

stamblerre opened this issue Jan 29, 2020 · 5 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

This is a key missing piece in the gopls analysis suite, and it has come up repeatedly as an issue for editor clients (see microsoft/vscode-go#2517 for a recent example). Creating a tracking issue here since golint has its own issue tracker and its own issue for this (golang/lint#463).

Something worth considering is whether this means that golint will be moved into x/tools or if it should remain its separate repository.

/cc @matloob
@stamblerre stamblerre added this to the gopls unplanned milestone Jan 29, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 29, 2020
@stamblerre stamblerre added the gopls Issues related to the Go language server, gopls. label Jan 29, 2020
@matloob
Copy link
Contributor

matloob commented Jan 29, 2020

cc @hyangah, who I think has done some work on this.

I think golist should stay in a separate repository. We could put the passes in tools (though I'd prefer not to) but the binary itself should not be in tools.

@stamblerre stamblerre added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Jan 29, 2020
@stamblerre stamblerre modified the milestones: gopls unplanned, Unreleased Jan 29, 2020
@stamblerre
Copy link
Contributor Author

Seems like @hyangah has a stack of changes to convert golint to go/analysis, starting with CL 212797. I think that if these CLs go in, we can start adding them into gopls.

@stamblerre
Copy link
Contributor Author

/cc @ridersofrohan

@dominikh
Copy link
Member

Relevant: #38968

@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@mvdan
Copy link
Member

mvdan commented May 8, 2021

#38968 is accepted and golint is deprecated and being frozen this week - closing.

@mvdan mvdan closed this as completed May 8, 2021
@stamblerre stamblerre removed this from the gopls/unplanned milestone May 10, 2021
@golang golang locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dominikh @mvdan @stamblerre @gopherbot @matloob