Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: memoize allKnownSubdirs on the snapshot #45974

Closed
stamblerre opened this issue May 5, 2021 · 2 comments
Closed

x/tools/gopls: memoize allKnownSubdirs on the snapshot #45974

stamblerre opened this issue May 5, 2021 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.1

Comments

@stamblerre
Copy link
Contributor

@findleyr profiled didChange and found that this function was taking up the most time in didModifyFiles events, so we should cache the directories on the snapshot.
@stamblerre stamblerre added this to the gopls/v0.6.12 milestone May 5, 2021
@stamblerre stamblerre self-assigned this May 5, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 5, 2021
@findleyr
Copy link
Member

findleyr commented May 5, 2021

This was mentioned in #45686, but a forthcoming benchmark suggests that allKnownSubdirs accounts for more than half of the time it takes to process (but not diagnose) a file change.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/317410 mentions this issue: internal/lsp: memoize allKnownSubdirs instead of recomputing

@stamblerre stamblerre modified the milestones: gopls/v0.7.0, gopls/v0.7.1 Jun 4, 2021
@golang golang locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.1
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr