x/build/cmd/releasebot: pushing issues and closing milestone didn't work for major release

[dmitshur]

There seems to be a problem in pushIssues for major releases. It's documented to move issues for major releases:

// pushIssues moves open issues to the milestone of the next release of the same kind.
// For major releases, it's the milestone of the next major release (e.g., 1.14 → 1.15).
// For minor releases, it's the milestone of the next minor release (e.g., 1.14.1 → 1.14.2).
// For other release types, it does nothing.
func (w *Work) pushIssues()

Yet it didn't move issues for the Go 1.17 release, issue #47719.

The milestone wasn't closed either, despite the log message:

2021/08/16 17:01:07 closing milestone go1.17

From a quick look, a hypothesis is that gopherbot may have incorrectly thought milestone was "go1.17" (lower-case 'g'), but it's actually "Go1.17", and maybe GitHub is case sensitive (or has become). Edit: This hypothesis wasn't right.

CC @golang/release, @mknyszek.

[dmitshur]

It worked fine for Go 1.18, moving 8 non-release-blocking issues from Go1.18 milestone to Go1.19 (as seen here).

There were some changes that might've helped, so maybe it was that, or maybe something else. Either way, closing because there's nothing more to do here for now.