Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/marker: timeouts in Test #64473

Closed
gopherbot opened this issue Nov 30, 2023 · 67 comments
Closed

x/tools/gopls/internal/test/marker: timeouts in Test #64473

gopherbot opened this issue Nov 30, 2023 · 67 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 30, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/fixedbugs/issue59944.txt (2s)
	Test/foldingrange/a.txt (15s)
	Test/foldingrange/a_lineonly.txt (5s)
	Test/foldingrange/bad.txt (13s)
	Test/highlight/highlight.txt (27s)
	Test/highlight/issue60435.txt (35s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc0016090a0, {0x1ea5078, 0xc00c6237d0}, {0xc0086001b0?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3e9
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00074d040, 0xc0004be960, 0xc00040c4b0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:768 +0x9c5
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00074d040)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:112 +0x46e
testing.tRunner(0xc00074d040, 0xc000385260)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 30, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2023-11-30 17:51 darwin-amd64-12_0 tools@83512c45 go@77397ffc x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/fixedbugs/issue59944.txt (2s)
	Test/foldingrange/a.txt (15s)
	Test/foldingrange/a_lineonly.txt (5s)
	Test/foldingrange/bad.txt (13s)
	Test/highlight/highlight.txt (27s)
	Test/highlight/issue60435.txt (35s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc0016090a0, {0x1ea5078, 0xc00c6237d0}, {0xc0086001b0?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3e9
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00074d040, 0xc0004be960, 0xc00040c4b0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:768 +0x9c5
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00074d040)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:112 +0x46e
testing.tRunner(0xc00074d040, 0xc000385260)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 30, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 30, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2023-11-30 17:51 darwin-amd64-11_0 tools@83512c45 go@77397ffc x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/codeaction/change_quote.txt (15s)
	Test/codeaction/extract_method.txt (16s)
	Test/codeaction/fill_struct.txt (27s)
	Test/codeaction/functionextraction.txt (27s)
	Test/implementation/issue43655.txt (4s)
	Test/rename/embed.txt (7s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc0088b8540, {0x1ea5078, 0xc00d3fe4b0}, {0xc007107f98?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3e9
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00032b380, 0xc000740960, 0xc0002dede0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:768 +0x9c5
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00032b380)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:112 +0x46e
testing.tRunner(0xc00032b380, 0xc000427fc8)
2023-11-30 17:51 darwin-amd64-12_0 tools@83512c45 go@76d90a34 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (12s)
	Test/codeaction/extract_method.txt (14s)
	Test/codeaction/fill_struct.txt (31s)

golang.org/x/tools/internal/event/export/metric.(*HistogramInt64Data).modify(0xc0008ae360, {0x78b3480?, 0x7eff340?, 0x7f25a20?}, {0x78acc00?, 0xc00b048de0?}, 0xc0055e8080)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/event/export/metric/data.go:233 +0x2f5
golang.org/x/tools/internal/event/export/metric.(*HistogramInt64Data).record(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/event/export/metric/data.go:243
...
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1690 +0x76
reflect.Value.call({0x7784740?, 0x78a5da0?, 0xc00b01bd00?}, {0x73d3384, 0x4}, {0xc02e1086c0, 0x5, 0xc000123860?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x7784740?, 0x78a5da0?, 0x78c5dc8?}, {0xc02e1086c0?, 0xc008444230?, 0x5?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc02124a1b0, 0xc0001a5bc0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:344 +0x227
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000093d40)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:166 +0xbae
testing.tRunner(0xc000093d40, 0xc00019e630)

— watchflakes

@bcmills bcmills changed the title x/tools/gopls/internal/test/marker: Test failures x/tools/gopls/internal/test/marker: timeouts in Test Nov 30, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-11-30 17:50 darwin-amd64-12_0 tools@5995d319 go@f7a79cb5 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/rename/embed.txt (6s)
	Test/rename/generics.txt (14s)
	Test/rename/issue39614.txt (19s)
	Test/rename/issue42134.txt (37s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc0010b6700, {0x1e9de40, 0xc005fef740}, {0xc00444a750?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc000589860, 0xc0002e3720, 0xc0003a8ea0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:768 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000589860)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:112 +0x44e
testing.tRunner(0xc000589860, 0xc00011ef60)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-11-30 17:51 darwin-amd64-11_0 tools@83512c45 go@f7a79cb5 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/completion/issue59096.txt (3s)
	Test/foldingrange/a.txt (0s)
	Test/format/issue59554.txt (5s)
	Test/highlight/highlight.txt (21s)
	Test/highlight/issue60435.txt (28s)
	Test/hover/std.txt (2m1s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc0317fb420, {0x1e9ddf0, 0xc02ef8d710}, {0xc006395698?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc0006d5860, 0xc0006875e0, 0xc0004afe30, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:768 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0006d5860)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:112 +0x44e
testing.tRunner(0xc0006d5860, 0xc000319860)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-11-30 17:50 darwin-amd64-11_0 tools@5995d319 go@77397ffc x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/codeaction/fill_struct.txt (22s)
	Test/codeaction/functionextraction.txt (22s)
	Test/links/links.txt (35s)
	Test/rename/embed.txt (9s)
	Test/rename/generics.txt (2s)
	Test/rename/generics_basic.txt (9s)

golang.org/x/tools/gopls/internal/lsp/regtest.(*Awaiter).Await(0xc005340460, {0x1ea50b8, 0xc02a228030}, {0xc0036e9e90?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:385 +0x3e9
golang.org/x/tools/gopls/internal/lsp/regtest.(*Env).Await(0xc026f607d0, {0xc0036e9e90, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:347 +0x65
golang.org/x/tools/gopls/internal/lsp/regtest.(*Env).OnceMet(0xc026f607d0, {0xc00a4f2100?, {0xc00b28e690?, 0x100e067?}}, {0xc0036e9d70, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/env.go:357 +0xfd
golang.org/x/tools/gopls/internal/lsp/regtest.(*Env).AfterChange(0xc026f607d0, {0xc0036e9d70, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/expectation.go:333 +0x67
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0003a04e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:133 +0x749
testing.tRunner(0xc0003a04e0, 0xc0001dc198)

— watchflakes

@adonovan
Copy link
Member

adonovan commented Dec 1, 2023

The first log look looks like a heavily overloaded machine: many threads are runnable, busily doing importing, analysis, typechecking, typerefs, etc. Various active RPCs have been waiting for 3 minutes. There are a large number of jsonrpc workers.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-01 18:26 darwin-amd64-nocgo tools@c4f958a6 go@77397ffc x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/completion/issue62560.txt (10s)
	Test/completion/issue62676.txt (8s)
	Test/completion/keywords.txt (8s)
	Test/completion/lit.txt (24s)
	Test/completion/multi_return.txt (24s)
	Test/hover/std.txt (1m37s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0302cba40, {0x1eaabd8, 0xc00a1d5140}, {0xc00a464570?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:385 +0x3e9
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc0005ab380, 0xc0005c18c0, 0xc00051f140, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:771 +0x9c5
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0005ab380)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:115 +0x46e
testing.tRunner(0xc0005ab380, 0xc000558048)

— watchflakes

@hyangah hyangah modified the milestones: Unreleased, gopls/backlog Dec 7, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-08 20:11 darwin-amd64-nocgo tools@c4e846a7 go@e1cba47e x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/fill_struct.txt (1m39s)
	Test/completion/issue62560.txt (5s)
	Test/completion/keywords.txt (4s)
	Test/completion/lit.txt (12s)
	Test/completion/multi_return.txt (14s)
	Test/completion/rank.txt (49s)

golang.org/x/tools/internal/jsonrpc2.(*conn).Call(0xc01fb039f0, {0x4d41898, 0xc01fca1740}, {0x4891a19, 0x17}, {0x4b89880?, 0xc011224e00?}, {0x4b9df80, 0xc01716bda0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/conn.go:138 +0x965
golang.org/x/tools/gopls/internal/lsp/protocol.clientConn.Call({{0x4d44e08, 0xc01fb039f0}}, {0x4d41898, 0xc01fca1740}, {0x4891a19?, 0x18?}, {0x4b89880?, 0xc011224e00?}, {0x4b9df80, 0xc01716bda0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/protocol.go:64 +0x75
golang.org/x/tools/gopls/internal/lsp/protocol.(*serverDispatcher).CodeAction(0xc00d5999b0, {0x4d41898, 0xc01fca1740}, 0xc011224e00)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/tsserver.go:848 +0x7f
golang.org/x/tools/gopls/internal/test/marker.codeActionChanges(0xc016301130, {0xc0080f0310, 0x69}, {{0xb?, 0x0?}, {0x10?, 0x0?}}, {0xc000211849, 0x10}, 0x0, ...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1839 +0x19c
golang.org/x/tools/gopls/internal/test/marker.codeAction(0xc016301130, {0xc0080f0310?, 0x28?}, {{0x38?, 0x0?}, {0x8460b00?, 0xc0?}}, {0xc000211849?, 0xc9bb798?}, 0x0, ...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1809 +0x6a
golang.org/x/tools/gopls/internal/test/marker.codeActionEditMarker({0xc01f3a5230?, 0xc0000f9e00?}, {{0xc0080f0310?, 0x0?}, {{0x0?, 0x0?}, {0x0?, 0x0?}}}, {0xc000211849, 0x10}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1681 +0x98
reflect.Value.call({0x4c11000?, 0x4d32ed8?, 0xc000203710?}, {0x485c6c0, 0x4}, {0xc00cc3eba0, 0x4, 0xc000203720?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x4c11000?, 0x4d32ed8?, 0x4d52f28?}, {0xc00cc3eba0?, 0xc014eb4f40?, 0x4?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc01f3a5230, 0xc0000f9e00})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:347 +0x227
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000509ba0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:169 +0xbae
testing.tRunner(0xc000509ba0, 0xc0002a7bc0)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-08 22:31 darwin-amd64-nocgo tools@8e821ab4 go@fe1b2f95 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (17s)
	Test/codeaction/fill_struct.txt (1m29s)
	Test/completion/issue60545.txt (10s)
	Test/completion/issue62141.txt (10s)
	Test/completion/lit.txt (52s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc02d2ef260, {0x4996af8, 0xc01777fb30}, {0xc0044efcf8, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:385 +0x3c9
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc003e808c0, {0xc0044efcf8, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:347 +0x5e
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc003e808c0, {0xc0092357e0?, {0xc015e9c4b0?, 0x3aab1c5?}}, {0xc0044efc80, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:357 +0xe9
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc003e808c0, {0xc0044efc80, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x5e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0000b2340)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:136 +0x725
testing.tRunner(0xc0000b2340, 0xc000390168)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-11 17:56 darwin-amd64-nocgo tools@6823dc40 go@bbab863a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/completion/builtins.txt (1s)
	Test/foldingrange/a.txt (14s)
	Test/foldingrange/a_lineonly.txt (10s)
	Test/foldingrange/bad.txt (13s)
	Test/highlight/highlight.txt (26s)
	Test/highlight/issue60435.txt (30s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0214e1340, {0x1ea4fb0, 0xc00e283020}, {0xc0038204b0?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:385 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00057d040, 0xc00055a140, 0xc0005e00f0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:771 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00057d040)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:115 +0x44e
testing.tRunner(0xc00057d040, 0xc0005606d8)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-11 22:21 darwin-amd64-11_0 tools@113a0814 go@e872807e x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/type_params.txt (13s)
	Test/diagnostics/usemodule.txt (4s)
	Test/highlight/highlight.txt (1m16s)
	Test/rename/embed.txt (15s)
	Test/rename/generics.txt (15s)
	Test/rename/issue42134.txt (20s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc00dcea7e0, {0xda84c58, 0xc031a55410}, {0xc003a031a0, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:385 +0x3c9
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc0037a01e0, {0xc003a031a0, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:347 +0x5e
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc0037a01e0, {0xc00306f1c0?, {0xc0009ccfa0?, 0xcb96e85?}}, {0xc003a03128, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:357 +0xe9
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc0037a01e0, {0xc003a03128, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x5e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000525040)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:136 +0x725
testing.tRunner(0xc000525040, 0xc000377140)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-12 13:56 darwin-amd64-12_0 tools@bbc30f1f go@b18b0588 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/diagnostics/usemodule.txt (13s)
	Test/rename/embed.txt (13s)
	Test/rename/generics.txt (15s)
	Test/rename/generics_basic.txt (15s)
	Test/rename/issue42134.txt (27s)

net.(*pipeDeadline).wait(0xc00304f2b8?)
	/tmp/buildlet/go/src/net/pipe.go:68 +0x31
...
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:511 +0xcb
golang.org/x/tools/gopls/internal/test/integration/fake.(*Editor).createBuffer(0xc007996b08, {0xb6f4f38, 0xc0257956e0}, {0xc0003f23a0, 0x8}, 0x0, {0xc00f069e00, 0x1b, 0x200})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:494 +0x3c5
golang.org/x/tools/gopls/internal/test/integration/fake.(*Editor).OpenFile(0xc007996b08, {0xb6f4f38, 0xc0257956e0}, {0xc0003f23a0, 0x8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:441 +0x145
golang.org/x/tools/gopls/internal/test/integration.(*Env).OpenFile(0xc00d96a460, {0xc0003f23a0, 0x8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/wrappers.go:69 +0x54
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00067d6c0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:131 +0x645
testing.tRunner(0xc00067d6c0, 0xc0002a38a8)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-14 03:15 darwin-amd64-12_0 tools@20e1bb71 go@bbab863a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/completion/unsafe.txt (3s)
	Test/definition/embed.txt (18s)
	Test/definition/import.txt (11s)
	Test/definition/misc.txt (17s)
	Test/diagnostics/analyzers.txt (18s)
	Test/diagnostics/issue56943.txt (32s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0097969a0, {0x1eaad50, 0xc011ed60c0}, {0xc00d50cf48?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc000670ea0, 0xc0004a4be0, 0xc00057e570, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:800 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000670ea0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:140 +0x44e
testing.tRunner(0xc000670ea0, 0xc000286648)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-15 21:59 darwin-amd64-nocgo tools@4d2b6e1d go@9b4b3e5a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (11s)
	Test/codeaction/extract_method.txt (19s)
	Test/codeaction/extract_variable.txt (17s)
	Test/codeaction/fill_struct.txt (46s)
	Test/codeaction/functionextraction.txt (34s)

net.(*pipe).write(0xc0063a3000, {0xc0012add40, 0x118, 0x120})
	/tmp/buildlet/go/src/net/pipe.go:196 +0x31a
...
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1711 +0x98
reflect.Value.call({0x108769a0?, 0x10998ad8?, 0xc00011e4a0?}, {0x104c3190, 0x4}, {0xc00dc3f080, 0x5, 0xc00011e4a0?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x108769a0?, 0x10998ad8?, 0x109b8ae8?}, {0xc00dc3f080?, 0xc00602ac80?, 0x5?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc010df4f30, 0xc0002461e0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:375 +0x227
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00055b520)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:194 +0xbae
testing.tRunner(0xc00055b520, 0xc0000ff0b0)
2023-12-15 23:31 darwin-amd64-12_0 tools@261fa1a5 go@8cb86b5f x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/fixedbugs/issue59318.txt (21s)
	Test/implementation/generics.txt (8s)
	Test/implementation/issue43655.txt (11s)
	Test/inlayhints/inlayhints.txt (35s)
	Test/links/links.txt (23s)

encoding/json.(*encodeState).marshal(0xc0085b6f00?, {0x1b7eee0?, 0xc003959d60?}, {0x0?, 0x1?})
...
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/conn.go:131 +0x80f
golang.org/x/tools/gopls/internal/lsp/protocol.clientConn.Call({{0x1ea9c18, 0xc00a4305f0}}, {0x1ea6f88, 0xc00003a080}, {0x1bfc6c1?, 0xc00f94f7c0?}, {0x0?, 0x0?}, {0x0, 0x0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/protocol.go:65 +0x83
golang.org/x/tools/gopls/internal/lsp/protocol.(*serverDispatcher).Shutdown(0x5?, {0x1ea6f88?, 0xc00003a080?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/tsserver.go:923 +0x43
golang.org/x/tools/gopls/internal/test/integration/fake.(*Editor).Shutdown(0xc004a978d0?, {0x1ea6f88?, 0xc00003a080?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:171 +0x37
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000191860)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:238 +0x1051
testing.tRunner(0xc000191860, 0xc0002b1500)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-15 21:59 darwin-amd64-nocgo tools@4d2b6e1d go@8cb86b5f x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/codeaction/fill_struct.txt (27s)
	Test/codeaction/functionextraction.txt (30s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0093bca80, {0x1ea74f8, 0xc004527620}, {0xc002a12900?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3e9
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc013f07c70, {0xc002a12900, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:336 +0x65
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc013f07c70, {0xc0048d2b40?, {0xc00adc94f0?, 0x100e067?}}, {0xc002a12888, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:346 +0xfd
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc013f07c70, {0xc002a12888, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x67
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0003856c0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:161 +0x749
testing.tRunner(0xc0003856c0, 0xc0000b7140)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-18 18:59 darwin-amd64-nocgo tools@83bceaf2 go@8e3930f2 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/issue62676.txt (16s)
	Test/completion/keywords.txt (1s)
	Test/completion/labels.txt (12s)
	Test/completion/lit.txt (8s)
	Test/completion/rank.txt (58s)
	Test/rename/generics.txt (21s)

golang.org/x/tools/internal/jsonrpc2.(*conn).Call(0xc00e33bea0, {0x7876378, 0xc017e5ff50}, {0x73c6ee5, 0x17}, {0x76beb20?, 0xc0136f4cd0?}, {0x76d8a80, 0xc0172559d8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/conn.go:138 +0x965
golang.org/x/tools/gopls/internal/lsp/protocol.clientConn.Call({{0x7879908, 0xc00e33bea0}}, {0x7876378, 0xc017e5ff50}, {0x73c6ee5?, 0x8?}, {0x76beb20?, 0xc0136f4cd0?}, {0x76d8a80, 0xc0172559d8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/protocol.go:65 +0x75
golang.org/x/tools/gopls/internal/lsp/protocol.(*serverDispatcher).Completion(0xc0069a8160, {0x7876378, 0xc017e5ff50}, 0xc0136f4cd0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/tsserver.go:948 +0x78
golang.org/x/tools/gopls/internal/test/integration/fake.(*Editor).Completion(0xc00a2a4588, {0x7876378, 0xc017e5ff50}, {{0xc007fda960?, 0xc011031f40?}, {{0x2434e78?, 0xc0?}, {0x6986378?, 0x0?}}})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:1114 +0x189
golang.org/x/tools/gopls/internal/test/integration.(*Env).Completion(0xc002f2a5f0, {{0xc007fda960?, 0xc00736aa48?}, {{0x2434ef0?, 0xc0?}, {0x6a0076f?, 0x0?}}})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/wrappers.go:501 +0x88
golang.org/x/tools/gopls/internal/test/marker.acceptCompletionMarker({0xc00f4515f0?, 0xc00016ab40?}, {{0xc007fda960?, 0xc0162279b0?}, {{0x0?, 0x0?}, {0x0?, 0x0?}}}, {0xc0004a4c69, 0x4}, ...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1358 +0x6a
reflect.Value.call({0x772fc60?, 0x78679d0?, 0xc0000fcf80?}, {0x7391c10, 0x4}, {0xc000ec1a40, 0x4, 0xc0000fcf90?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x772fc60?, 0x78679d0?, 0x78879c8?}, {0xc000ec1a40?, 0xc0060c5540?, 0x4?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc00f4515f0, 0xc00016ab40})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:375 +0x227
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00046d380)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:194 +0xbae
testing.tRunner(0xc00046d380, 0xc000414978)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-18 20:38 darwin-amd64-12_0 tools@c431729b go@bbab863a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/codeaction/removeparam_formatting.txt (5s)
	Test/codeaction/removeparam_funcvalue.txt (18s)
	Test/codeaction/removeparam_imports.txt (19s)
	Test/codelens/test.txt (27s)
	Test/completion/address.txt (37s)
	Test/suggestedfix/stub.txt (1m30s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc00c480700, {0x1e9fbf0, 0xc02a0450b0}, {0xc006b01ab8?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00077f1e0, 0xc00075d300, 0xc0003e7920, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:800 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00077f1e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:140 +0x44e
testing.tRunner(0xc00077f1e0, 0xc0001fba70)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-18 20:56 darwin-amd64-nocgo tools@ee47fd47 go@5b84d500 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/complit.txt (34s)
	Test/completion/issue59096.txt (1s)
	Test/completion/issue60545.txt (5s)
	Test/completion/issue62560.txt (9s)
	Test/completion/issue62676.txt (16s)
	Test/completion/lit.txt (44s)

golang.org/x/tools/internal/jsonrpc2.(*conn).Call(0xc00cd6f5e0, {0x9e111b8, 0xc00c559050}, {0x9961fa4, 0x17}, {0x9c59ac0?, 0xc011ec4ff0?}, {0x9c73a20, 0xc030c79db8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/conn.go:138 +0x965
golang.org/x/tools/gopls/internal/lsp/protocol.clientConn.Call({{0x9e14748, 0xc00cd6f5e0}}, {0x9e111b8, 0xc00c559050}, {0x9961fa4?, 0x8?}, {0x9c59ac0?, 0xc011ec4ff0?}, {0x9c73a20, 0xc030c79db8})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/protocol.go:65 +0x75
golang.org/x/tools/gopls/internal/lsp/protocol.(*serverDispatcher).Completion(0xc0084e3660, {0x9e111b8, 0xc00c559050}, 0xc011ec4ff0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/protocol/tsserver.go:948 +0x78
golang.org/x/tools/gopls/internal/test/integration/fake.(*Editor).Completion(0xc004bf1608, {0x9e111b8, 0xc00c559050}, {{0xc0070c2f50?, 0xc00aff0960?}, {{0x9e0fd70?, 0x0?}, {0xccc9a40?, 0xc0?}}})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/editor.go:1114 +0x189
golang.org/x/tools/gopls/internal/test/integration.(*Env).Completion(0xc00c9b0e10, {{0xc0070c2f50?, 0x9c6d840?}, {{0x10d81d88?, 0xc0?}, {0x0?, 0x0?}}})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/wrappers.go:501 +0x88
golang.org/x/tools/gopls/internal/test/marker.completeMarker({0xc00abd4ab0?, 0xc0005c07b0?}, {{0xc0070c2f50?, 0x8?}, {{0x0?, 0x0?}, {0x0?, 0x0?}}}, {0xc00a24d800, 0x2, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1294 +0x65
reflect.Value.call({0x9cb5440?, 0x9e02818?, 0xc0070fd040?}, {0x992ccb0, 0x4}, {0xc007772600, 0x4, 0xc0005c2990?})
	/tmp/buildlet/go/src/reflect/value.go:596 +0xce5
reflect.Value.Call({0x9cb5440?, 0x9e02818?, 0x9e22808?}, {0xc007772600?, 0xc00ccc9ac0?, 0x4?})
	/tmp/buildlet/go/src/reflect/value.go:380 +0xb9
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc00abd4ab0, 0xc0005c07b0})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:375 +0x227
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0006ff1e0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:194 +0xbae
testing.tRunner(0xc0006ff1e0, 0xc0000d61b0)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-18 20:56 darwin-amd64-12_0 tools@ee47fd47 go@90daaa05 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/issue60545.txt (31s)
	Test/hover/const.txt (3s)
	Test/hover/generics.txt (23s)
	Test/hover/godef.txt (55s)
	Test/implementation/generics.txt (15s)
	Test/implementation/issue43655.txt (19s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0422b0000, {0x73901d8, 0xc00d9526c0}, {0xc0124d83d8, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3c9
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc00ab19590, {0xc0124d83d8, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:336 +0x5e
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc00ab19590, {0xc00349a460?, {0xc003560be0?, 0x64aae85?}}, {0xc0124d8348, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:346 +0xe9
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc00ab19590, {0xc0124d8348, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x5e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000768ea0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:161 +0x725
testing.tRunner(0xc000768ea0, 0xc0001faa38)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-18 18:59 darwin-amd64-nocgo tools@83bceaf2 go@08bec0db x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (15s)
	Test/codeaction/fill_struct.txt (40s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc00083cb60, {0xd651378, 0xc00c9192f0}, {0xc0350c7c08, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3c9
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc00a030c30, {0xc0350c7c08, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:336 +0x5e
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc00a030c30, {0xc008ed0520?, {0xc02292e460?, 0xc76b1c5?}}, {0xc0350c7b90, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:346 +0xe9
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc00a030c30, {0xc0350c7b90, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x5e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc000485520)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:161 +0x725
testing.tRunner(0xc000485520, 0xc0002ab950)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-19 22:22 darwin-amd64-12_0 tools@160631f7 go@a2a2c5b9 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/fixedbugs/issue59944.txt (7s)
	Test/foldingrange/a.txt (12s)
	Test/foldingrange/a_lineonly.txt (12s)
	Test/foldingrange/bad.txt (25s)
	Test/format/format.txt (13s)
	Test/highlight/highlight.txt (1m25s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0340b5ea0, {0x101a21f8, 0xc00db39ad0}, {0xc007637278, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3c9
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc0002a1860, 0xc0002e09a0, 0xc0001ed5f0, 0x0, {0x0, 0x0, 0xc000558b90?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:800 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0002a1860)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:140 +0x44e
testing.tRunner(0xc0002a1860, 0xc0001a50f8)
2023-12-19 22:22 darwin-amd64-12_0 tools@160631f7 go@bbab863a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/foldingrange/a.txt (9s)
	Test/foldingrange/a_lineonly.txt (2s)
	Test/foldingrange/bad.txt (4s)
	Test/highlight/highlight.txt (18s)
	Test/highlight/issue60435.txt (22s)
	Test/hover/std.txt (1m28s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc0065441c0, {0x1e9ecd0, 0xc020b748a0}, {0xc009783428?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc0003f3860, 0xc00027f7e0, 0xc00026ba40, 0x0, {0x0, 0x0, 0xc000180140?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:800 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0003f3860)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:140 +0x44e
testing.tRunner(0xc0003f3860, 0xc000497a70)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2023-12-21 20:12 darwin-amd64-12_0 tools@59384bce go@bbab863a x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test (10m0s)
	Test/codeaction/invertif.txt (9s)
	Test/codeaction/issue64558.txt (16s)
	Test/codeaction/removeparam.txt (22s)
	Test/completion/issue62560.txt (5s)
	Test/completion/rank.txt (1m25s)
	Test/diagnostics/strangefiles.txt (6s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc02a910540, {0x1e9fbd0, 0xc0182dc7e0}, {0xc02976d320?, 0x1, 0x1})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3ca
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00053cea0, 0xc0000af2a0, 0xc0001682a0, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:800 +0x96e
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00053cea0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:140 +0x44e
testing.tRunner(0xc00053cea0, 0xc000327a70)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-02 20:27 x_tools-go1.21-solaris-amd64 tools@c3f60b78 release-branch.go1.21@2fdad8af x/tools/gopls/internal/test/marker.Test [ABORT] (log) 
=== RUN   Test/completion/snippet.txt
=== PAUSE Test/completion/snippet.txt
=== CONT  Test/completion/snippet.txt
panic: test timed out after 10m0s
running tests:
	Test (10m1s)
	Test/completion/printf.txt (22s)
	Test/completion/snippet.txt (2s)
	Test/completion/snippet_placeholder.txt (5s)
	Test/completion/statements.txt (6s)
...
golang.org/x/tools/gopls/internal/cache.(*Snapshot).ModTidy.func1({0x12b3738, 0xc004273130}, {0xfe1580?, 0xc0109b2ea0})
	/opt/golang/swarm/.swarming/w/ir/x/w/targetrepo3467065418/gopls/internal/cache/mod_tidy.go:80 +0x87
golang.org/x/tools/internal/memoize.(*Promise).run.func2.1()
	/opt/golang/swarm/.swarming/w/ir/x/w/targetrepo3467065418/internal/memoize/memoize.go:187 +0x9c
runtime/trace.WithRegion({0x12b3738?, 0xc004273130?}, {0xc012ac7e78, 0x13}, 0xc0021d2f90)
	/opt/golang/swarm/.swarming/w/ir/x/w/goroot/src/runtime/trace/annotation.go:141 +0xdd
golang.org/x/tools/internal/memoize.(*Promise).run.func2()
	/opt/golang/swarm/.swarming/w/ir/x/w/targetrepo3467065418/internal/memoize/memoize.go:180 +0x138
created by golang.org/x/tools/internal/memoize.(*Promise).run in goroutine 161651
	/opt/golang/swarm/.swarming/w/ir/x/w/targetrepo3467065418/internal/memoize/memoize.go:179 +0x1c7

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/562035 mentions this issue: gopls/internal/test/marker: skip on LUCI solaris builders

@gopherbot gopherbot reopened this Feb 7, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-07 20:13 freebsd-amd64-race tools@e3f11805 go@e55bf08d x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (8s)
	Test/codeaction/fill_struct_resolve.txt (2m3s)
	Test/completion/variadic.txt (23s)
	Test/definition/embed.txt (16s)
	Test/definition/misc.txt (1m6s)
	Test/definition/standalone.txt (9s)
	Test/diagnostics/analyzers.txt (20s)
	Test/diagnostics/excludedfile.txt (1m9s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc00938c0e0, {0x1b24468, 0xc00b2960c0}, {0xc012800468, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3d1
golang.org/x/tools/gopls/internal/test/marker.newEnv(0xc00012f040, 0xc00070f980, 0xc000233b60, 0x0, {0x0, 0x0, 0x0?}, {{0x0, 0x0}, 0x0, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:819 +0x1185
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc00012f040)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:150 +0x6c5
testing.tRunner(0xc00012f040, 0xc00023ee70)

— watchflakes

@findleyr
Copy link
Member

findleyr commented Feb 7, 2024

Slow legacy builder -- plenty of runnable goroutines. Looking at history, freebsd race builder typically takes 300s-450s. Flake seems very unlikely, so I'd rather ignore it than eagerly skip. Can reconsider if watchflakes opens the issue again.

@findleyr findleyr closed this as completed Feb 7, 2024
@gopherbot gopherbot reopened this Feb 16, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-16 17:49 freebsd-amd64-race tools@c61f99f1 go@6cbe522f x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/lit.txt (1m4s)
	Test/completion/unresolved.txt (3s)
	Test/completion/variadic.txt (23s)
	Test/configuration/static.txt (12s)
	Test/definition/cgo.txt (15s)
	Test/definition/misc.txt (12s)
	Test/diagnostics/analyzers.txt (36s)
	Test/rename/issue39614.txt (3s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0xc032e30d20, {0x1b34de8, 0xc011b097a0}, {0xc00ca10948, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x3d1
golang.org/x/tools/gopls/internal/test/integration.(*Env).Await(0xc018a24aa0, {0xc00ca10948, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:336 +0xab
golang.org/x/tools/gopls/internal/test/integration.(*Env).OnceMet(0xc018a24aa0, {0xc012202560?, {0xc007b892c0?, 0x46c445?}}, {0xc00ca108d0, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:346 +0x127
golang.org/x/tools/gopls/internal/test/integration.(*Env).AfterChange(0xc018a24aa0, {0xc00ca108d0, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/expectation.go:333 +0x76
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0004a09c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:171 +0xce6
testing.tRunner(0xc0004a09c0, 0xc00012a258)

— watchflakes

@findleyr
Copy link
Member

findleyr commented Feb 16, 2024 •
edited
Loading

Another legacy builder, with runnable goroutines. Not investing a lot of time in these during the LUCI migration.

@gopherbot gopherbot reopened this Feb 16, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-16 22:46 freebsd-amd64-race tools@51dec259 go@1c9c9c84 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (13s)
	Test/codeaction/extract_method.txt (16s)
	Test/codeaction/fill_struct.txt (42s)
	Test/codeaction/fill_struct_resolve.txt (28s)
	Test/codeaction/functionextraction.txt (19s)
	Test/completion/issue56505.txt (0s)
	Test/completion/issue59096.txt (5s)
	Test/completion/issue60545.txt (1s)
...
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:1751 +0xb7
reflect.Value.call({0x16439a0?, 0x18fc2d8?, 0xc00bc25698?}, {0x1769c3d, 0x4}, {0xc009b73980, 0x5, 0x58d657?})
	/tmp/workdir/go/src/reflect/value.go:587 +0xd5d
reflect.Value.Call({0x16439a0?, 0x18fc2d8?, 0x1b3c668?}, {0xc009b73980, 0x5, 0x8})
	/tmp/workdir/go/src/reflect/value.go:371 +0xb6
golang.org/x/tools/gopls/internal/test/marker.actionMarkerFunc.func1({0xc001264c00, 0xc00041d8f0})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:385 +0x2bf
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0001bf860)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:204 +0x153c
testing.tRunner(0xc0001bf860, 0xc0002320a8)

— watchflakes

@findleyr
Copy link
Member

We skip freebsd for our integration tests, and likely forgot to skip here. Will investigate.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-20 20:33 freebsd-amd64-race tools@3f67f80b go@29083529 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/codeaction/change_quote.txt (23s)
	Test/codeaction/fill_struct.txt (1m10s)
	Test/codeaction/fill_struct_resolve.txt (1m13s)
	Test/references/issue59851.txt (11s)
	Test/references/issue60369.txt (8s)
	Test/references/issue60676.txt (11s)
	Test/rename/issue61640.txt (3s)
	Test/signature/signature.txt (26s)

golang.org/x/tools/internal/gocommand.runCmdContext({0x1b2bf00, 0x22afd40}, 0xc019ccfa20)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:379 +0x829
golang.org/x/tools/internal/gocommand.(*Invocation).run(0xc008a7d030, {0x1b2bf00, 0x22afd40}, {0x1b22740, 0xc00bd333b0}, {0x1b22740, 0xc00bd333e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:270 +0x1710
golang.org/x/tools/internal/gocommand.(*Invocation).runWithFriendlyError(0xc008a7d030, {0x1b2bf00, 0x22afd40}, {0x1b22740, 0xc00bd333b0}, {0x1b22740, 0xc00bd333e0})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:179 +0x9c
golang.org/x/tools/internal/gocommand.(*Runner).runConcurrent(0xc008097718, {0x1b2bf00, 0x22afd40}, {{0x176d3bc, 0x5}, {0xc00e733720, 0x1, 0x1}, {0x0, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:121 +0x27e
golang.org/x/tools/internal/gocommand.(*Runner).RunRaw(0xc008097718, {0x1b2bf00, 0x22afd40}, {{0x176d3bc, 0x5}, {0xc00e733720, 0x1, 0x1}, {0x0, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:95 +0x415
golang.org/x/tools/gopls/internal/test/integration/fake.(*Sandbox).RunGoCommand(0xc0080976e0, {0x1b2bf00, 0x22afd40}, {0x0, 0x0}, {0x176d3bc, 0x5}, {0xc00e733720, 0x1, 0x1}, ...)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/sandbox.go:264 +0x2eb
golang.org/x/tools/gopls/internal/test/integration/fake.(*Sandbox).Close(0xc0080976e0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/sandbox.go:292 +0xf4
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0004cda00)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:248 +0x1bd4
testing.tRunner(0xc0004cda00, 0xc0003aa030)

— watchflakes

@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Feb 21, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-02-20 20:33 freebsd-amd64-race tools@3f67f80b go@3580c212 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/completion/variadic.txt (25s)
	Test/definition/cgo.txt (12s)
	Test/diagnostics/analyzers.txt (47s)
	Test/diagnostics/excludedfile.txt (49s)

golang.org/x/tools/internal/gocommand.runCmdContext({0x1b2bf00, 0x22afd40}, 0xc010f0e160)
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:379 +0x829
golang.org/x/tools/internal/gocommand.(*Invocation).run(0xc0025e3030, {0x1b2bf00, 0x22afd40}, {0x1b22740, 0xc011ed1ef0}, {0x1b22740, 0xc011ed1f20})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:270 +0x1710
golang.org/x/tools/internal/gocommand.(*Invocation).runWithFriendlyError(0xc0025e3030, {0x1b2bf00, 0x22afd40}, {0x1b22740, 0xc011ed1ef0}, {0x1b22740, 0xc011ed1f20})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:179 +0x9c
golang.org/x/tools/internal/gocommand.(*Runner).runConcurrent(0xc00668e098, {0x1b2bf00, 0x22afd40}, {{0x176d3bc, 0x5}, {0xc0074739a0, 0x1, 0x1}, {0x0, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:121 +0x27e
golang.org/x/tools/internal/gocommand.(*Runner).RunRaw(0xc00668e098, {0x1b2bf00, 0x22afd40}, {{0x176d3bc, 0x5}, {0xc0074739a0, 0x1, 0x1}, {0x0, 0x0, ...}, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:95 +0x415
golang.org/x/tools/gopls/internal/test/integration/fake.(*Sandbox).RunGoCommand(0xc00668e060, {0x1b2bf00, 0x22afd40}, {0x0, 0x0}, {0x176d3bc, 0x5}, {0xc0074739a0, 0x1, 0x1}, ...)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/sandbox.go:264 +0x2eb
golang.org/x/tools/gopls/internal/test/integration/fake.(*Sandbox).Close(0xc00668e060)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/fake/sandbox.go:292 +0xf4
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0xc0000a76c0)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:248 +0x1bd4
testing.tRunner(0xc0000a76c0, 0xc000399d70)

— watchflakes

@findleyr findleyr mentioned this issue Feb 21, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/566055 mentions this issue: dashboard: increase the timeout of freebsd-amd64-race

@gopherbot gopherbot reopened this Mar 25, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-03-21 20:17 netbsd-386-9_3 tools@3f9badb7 go@1c864333 x/tools/gopls/internal/test/marker.Test (log) 
panic: test timed out after 10m0s
running tests:
	Test/rename/testy.txt (9m16s)

golang.org/x/tools/gopls/internal/test/integration.(*Awaiter).Await(0x17afd200, {0x8ebd4c4, 0xf902e70}, {0xf20b7e0, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/env.go:374 +0x264
golang.org/x/tools/gopls/internal/test/marker.newEnv(0x9b57c08, 0x9cc4120, 0x9d966a0, 0x0, {0x0, 0x0, 0x0}, {{0x0, 0x0}, 0x0, ...})
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:816 +0x8ed
golang.org/x/tools/gopls/internal/test/marker.Test.func1(0x9b57c08)
	/tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/marker/marker_test.go:151 +0x48b
testing.tRunner(0x9b57c08, 0x98137c0)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && log ~ `panic: test timed out`
2024-03-25 21:28 x_tools-gotip-darwin-amd64_11 tools@2c8dd3ec go@e7bdc881 x/tools/gopls/internal/test/marker.Test [ABORT] (log) 
=== RUN   Test

— watchflakes

@findleyr
Copy link
Member

I think we've mitigated these on Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.16.0
Development

No branches or pull requests
4 participants
@hyangah @adonovan @gopherbot @findleyr