x/tools/gopls: panic in ast.Walk

[danp]

Getting this panic using gopls golang/tools@a1fbc78 and Go tip:

runtime.gopanic:59
runtime.panicmem:?261
go/ast.Walk:184
go/ast.Inspect:?397
golang.org/x/tools/gopls/internal/golang.highlightPath:29
golang.org/x/tools/gopls/internal/golang.Highlight:31
golang.org/x/tools/gopls/internal/server.(*server).DocumentHighlight:14
golang.org/x/tools/gopls/internal/protocol.serverDispatch:280
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:5
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:52
golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:2
golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:3
runtime.goexit:0

Noticed since gopls was exiting, sourced this stack from my local telemetry data. I assume it will be uploaded at some point but wanted to bring it up.

Maybe related to golang/tools@85146f5 / #60589?

[findleyr]

Indeed, this is almost certainly a new crash introduced by my CL. Thanks!

[adonovan]

Congratulations: you discovered the the first auto-reported crash to pass through the new machinery that landed on Friday!

[findleyr]

I definitely left that panic in my CL to exercise the new machinery... 😅

[gopherbot]

Change https://go.dev/cl/561435 mentions this issue: gopls/internal/golang: add missing check for nil funcBody

[gopherbot]

Change https://go.dev/cl/561517 mentions this issue: runtime: report inlined frames in Frames.Next