Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: references query does not count positional assignments to struct fields #67808

Closed
zhiqiangxu opened this issue May 30, 2024 · 2 comments
Closed

x/tools/gopls: references query does not count positional assignments to struct fields #67808

zhiqiangxu opened this issue May 30, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@zhiqiangxu
Copy link
Contributor

Here're the steps to reproduce:

  1. git clone https://github.com/ethereum-optimism/op-geth
  2. git checkout optimism

Open with vscode, then cmd+left click disableTxPool field, it doesn't show the assignment to it here.

I guess vscode-go has a bug identifying positional assignments to struct field.
@zhiqiangxu zhiqiangxu mentioned this issue May 30, 2024
Closed
@hyangah hyangah changed the title vscode-go doesn't show assignment to struct field x/tools/gopls: references query does not count positional assignments to struct fields Jun 4, 2024
@hyangah
Copy link
Contributor

hyangah commented Jun 4, 2024

I could reproduce the problem. (just have a code with positional assignments)

Transferring to the gopls issue tracker.

@hyangah hyangah transferred this issue from golang/vscode-go Jun 4, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 4, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 4, 2024
@findleyr
Copy link
Member

findleyr commented Jun 4, 2024

Thanks. This is a dupe of #66356.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@zhiqiangxu @hyangah @gopherbot @findleyr