-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/sha3: no longer compatible with Go 1.18 after v0.24.0 #68147
Comments
that is not a version of go we still support. |
This reply is too arrogant. Since the |
Perhaps we should ask @FiloSottile, who caused the compilation problem, what his attitude is on this. |
We indeed don't support such old versions of Go. We put a lot of effort into making it possible to upgrade Go without breakage, partially so we don't have to worry about supporting older versions. It's true the go.mod says Go 1.18 though, which probably shouldn't. It caused confusion in #68035, too, and #68011 would have gotten a hint if the go.mod version was higher. This is really an instance of #47802, in general, but was not flagged by vet due to #46136 (comment). Questions for @golang/release: is there a policy on how to bump go.mod versions of x/ repos? @wwqgtxx maintainers have a thankless job, please don't attack them just because you don't appreciate a response. |
Maybe my wording is not appropriate, I apologize in advance, but it is not what the maintainer should do to ignore the three issues including this one. Regarding this issue, either the go version number in If the official compatibility policy for old versions has not been discussed internally, at least this issue should be kept open instead of being closed rudely. |
Yes, that's what we are discussing now, but again please be considerate and keep the conversation on the topic rather than on individual's actions you disagree with, unless strictly necessary. I promise it will lead to better outcomes anyway. |
Change https://go.dev/cl/594256 mentions this issue: |
@FiloSottile There isn't something written down beyond the Go release policy, but that policy suggests general golang.org/x modules (e.g., with user-facing importable packages) need to continue to support the current and previous major Go versions (with some exceptions like the one for x/build). That's 1.22 and 1.21 at this time. So it's fine to update the x/crypto module to use Go 1.20 language semantics by now, since all supported Go versions can handle that, and the 1.22/1.21 trybots should pass. |
Go version
go version go1.22.4 darwin/arm64
Output of
go env
in your module/workspace:What did you do?
I am updating golang.org/x/crypto to v0.24.0. Many third-party libraries and other x libraries also depend on this version.
What did you see happen?
It fails to compile with Go 1.18:
What did you expect to see?
Since many third-party libraries and other x libraries actually still compile under Go 1.18, and the go mod for x/crypto still use Go 1.18, it would be nice if crypto treated this as a bug.
subtle.XORBytes looks like a public version of the internal function crypto/cipher.xorBytes , if you don't want to copy a compat version of the old code for Go 1.18 you can linkname to it (I know linkname shouldn't be used, but maybe ok for older Go versions)
The text was updated successfully, but these errors were encountered: