x/tools/go/ast/astutil : Unparen bad use of go/ast Unparen

[Giulianos]

Go version

1.22.5

Output of go env in your module/workspace:

GO111MODULE='on'
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/gscaglioni/Library/Caches/go-build'
GOENV='/Users/gscaglioni/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/gscaglioni/go/pkg/mod'
GONOPROXY='github.asapp.dev/*,github.com/asappinc/*'
GONOSUMDB='github.asapp.dev/*,github.com/asappinc/*'
GOOS='darwin'
GOPATH='/Users/gscaglioni/go'
GOPRIVATE='github.asapp.dev/*,github.com/asappinc/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/gscaglioni/git/asapp/protobuf/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/5l/mkbf31ss7kgb5gnlh4nfhc6h0000gn/T/go-build4286188762=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

Execute a program that uses golang.org/x/tools/go/ast/astutil.

What did you see happen?

The following error:
golang.org/x/tools/go/ast/astutil/util.go:11:48: undefined: ast.Unparen

What did you expect to see?

To work properly. Actually I inspected last changes to Unparen function and I see that it was deprecated in cl/612038 using go/ast implementation. I didn't put too much time investigating this, but I think it should be something like this:

func Unparen(e ast.Expr) ast.Expr { return e.Unparen() }

[gabyhelp]

Related Issues and Documentation

• go/ast: add func Unparen(Expr) Expr #60061 (closed)
• go/types: types.CheckExpr returns error when 'FuncType' ast.Expr has TypeParams #65898 (closed)
• x/tools/go/ast/astutil: ast replace could not handled expression parsed from string #29615 (closed)
• cmd/go: `go test -race -coverpkg=all` AST-parser is broken #60403 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}