Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/synctest: defer on systemstack failures on android builders #70661

Closed
mknyszek opened this issue Dec 3, 2024 · 3 comments
Closed

testing/synctest: defer on systemstack failures on android builders #70661

mknyszek opened this issue Dec 3, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android release-blocker
Milestone
Go1.24

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Dec 3, 2024

Examples:

CC @neild @prattmic
@mknyszek mknyszek added OS-Android NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 3, 2024
@mknyszek mknyszek added this to the Backlog milestone Dec 3, 2024
@prattmic
Copy link
Member

prattmic commented Dec 3, 2024

This isn't specific to Android, I'm not sure why only Android fails.

Marking as release-blocker for now given this package is used for std testing.

@prattmic prattmic modified the milestones: Backlog, Go1.24 Dec 3, 2024
@neild
Copy link
Contributor

neild commented Dec 3, 2024

https://build.golang.org/log/69f5b8aca8dcd47bbe5ec18ac3434e3376d44d07 seems to be something else:

##### external linking, -buildmode=exe
"/data/local/tmp/go_android_exec/fips140test.test-198516/fips140test.test": error: Android 5.0 and later only support position-independent executables (-fPIE).
FAIL	crypto/internal/fips140test	0.064s
FAIL

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/633281 mentions this issue: runtime: avoid defer on system stack in synctestidle_c

@cherrymui cherrymui mentioned this issue Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android release-blocker
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
4 participants
@neild @mknyszek @prattmic @gopherbot