From 92077074d40106c4de535e3d6f3716dd54bedf5c Mon Sep 17 00:00:00 2001 From: Robert Findley Date: Tue, 14 Sep 2021 18:08:45 -0400 Subject: [PATCH] go/internal/gcimporter: skip TestIExportData_stdlib on go1.18 This test will fail on Go 1.18 once standard library changes are introduced that use generics. Skip it until iexport.go has been updated to support generics. Updates golang/go#48392 Change-Id: I0f779689daaf2bc3127affff633c883ed9d7289b Reviewed-on: https://go-review.googlesource.com/c/tools/+/349954 Trust: Robert Findley Run-TryBot: Robert Findley Reviewed-by: Robert Griesemer gopls-CI: kokoro TryBot-Result: Go Bot --- go/internal/gcimporter/iexport_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/go/internal/gcimporter/iexport_test.go b/go/internal/gcimporter/iexport_test.go index 53850111c74..b75d5398634 100644 --- a/go/internal/gcimporter/iexport_test.go +++ b/go/internal/gcimporter/iexport_test.go @@ -31,6 +31,7 @@ import ( "golang.org/x/tools/go/buildutil" "golang.org/x/tools/go/internal/gcimporter" "golang.org/x/tools/go/loader" + "golang.org/x/tools/internal/testenv" ) func readExportFile(filename string) ([]byte, error) { @@ -63,6 +64,7 @@ func iexport(fset *token.FileSet, pkg *types.Package) ([]byte, error) { } func TestIExportData_stdlib(t *testing.T) { + testenv.SkipAfterGo1Point(t, 17) if runtime.Compiler == "gccgo" { t.Skip("gccgo standard library is inaccessible") }