Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing strikethrough for deprecated functions #599

Closed
festo opened this issue Sep 2, 2020 · 3 comments
Closed

Missing strikethrough for deprecated functions #599

festo opened this issue Sep 2, 2020 · 3 comments

Comments

@festo
Copy link

festo commented Sep 2, 2020

What version of Go, VS Code & VS Code Go extension are you using?

  • Run go version to get version of Go
    • go version go1.13.1 darwin/amd64
  • Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
1.48.2 
a0479759d6e9ea56afa657e454193f72aef85bd0 
x64
  • Check your installed extensions to get the version of the VS Code Go extension
    • v0.16.1
  • Run go env to get the go development environment details
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/festo/Library/Caches/go-build"
GOENV="/Users/festo/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/festo/projects"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rw/8nr3dydx39xgdjs1hld1dws00000gn/T/go-build888602545=/tmp/go-build -gno-record-gcc-switches -fno-common"

Share the Go related settings you have added/edited

  "go.lintFlags": [
        "--fast"
 ],
"[go]": {
    "editor.formatOnSave": true
},
"go.lintTool": "golangci-lint",
"go.useLanguageServer": true,
"go.formatTool": "gofmt",

Describe the bug

The editor doesn't mark deprecated functions with a strikethrough

Steps to reproduce the behaviour:

  1. Mark a function with // Deprecated: ... comment
  2. Use the function somewhere
  3. See error

Screenshots or recordings

Screenshot 2020-09-02 at 14 35 47

@hyangah
Copy link
Contributor

hyangah commented Sep 2, 2020

Language server can provide the deprecation diagnostic tag,
and it looks like there is already a feature request in gopls side
golang/go#40447.

cc @stamblerre

@stamblerre
Copy link
Contributor

Yep, let's close this as a duplicate.

@stamblerre
Copy link
Contributor

Duplicate of golang/go#40447

@stamblerre stamblerre marked this as a duplicate of golang/go#40447 Sep 2, 2020
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants