Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing (silently) on Windows #1382

Closed
Nivl opened this issue Sep 21, 2020 · 2 comments · Fixed by #3134
Closed

CI is failing (silently) on Windows #1382

Nivl opened this issue Sep 21, 2020 · 2 comments · Fixed by #3134
Labels
area: ci PR that update CI bug Something isn't working platform: windows Issue that is related to Windows

Comments

@Nivl
Copy link
Contributor

Nivl commented Sep 21, 2020

I'm not sure how related to the other Windows issues this is, but the Windows CI seems to be consistently failing (the errors are being ignored so it always shows the "passing" status). You can see the error here: https://github.com/golangci/golangci-lint/runs/1141826954 after I removed the option to stop ignoring errors.

To repro it's simple:

  1. Remove continue-on-error: true from the tests-on-windows job in .github/workflow/pr.yml
  2. Create a PR to run the CI.

The error seems to be related to gofmt and might be related to #580. I don't have a Windows machine, so I'd rather let this to Windows people to figure it out.

@Nivl Nivl added bug Something isn't working platform: windows Issue that is related to Windows area: ci PR that update CI labels Sep 21, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@Nivl Nivl changed the title CI is failing on Windows CI is failing (silently) on Windows Sep 21, 2020
@stale
Copy link

stale bot commented Sep 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Sep 22, 2021
@ldez ldez removed the stale No recent correspondence or work activity label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI bug Something isn't working platform: windows Issue that is related to Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants