gci auto fix is broken

[Dreamacro]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc).
• Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

gci only report issues but it won't fix it

Version of golangci-lint

$ golangci-lint --version
golangci-lint has version v1.44.1

Configuration file

$ cat .golangci.yml
linters:
  disable-all: true
  enable:
    - gofumpt
    - govet
    - gci

issues:
  fix: true

linters-settings:
  gci:
    sections:
      - standard
      - prefix(github.com/pkg/pkg)
      - default

Go environment

$ go version && go env
go version go1.17.6 darwin/arm64

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
INFO [runner] linters took 924.918333ms with stages: goanalysis_metalinter: 924.218458ms
INFO fixer took 0s with no stages
component/dialer/bind_darwin.go:7:4: Expected 'i', Found 'o' at component/dialer/bind_darwin.go[line 7,col 4] (gci)
	"golang.org/x/sys/unix"
	  ^
INFO File cache stats: 1 entries of total size 1.4KiB
INFO Memory: 13 samples, avg is 273.7MB, max is 352.6MB
INFO Execution took 1.127992166s

Code example or link to a public repository

import (
	"net"
	"syscall"

	"golang.org/x/sys/unix"

	"github.com/pkg/pkg"
)

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

Hello,

since the last gci update (#2532), autofix is no longer supported.

https://github.com/daixiang0/gci

[songkeys]

Could you please provide some suggestions on how we can get the auto-fix feature back?

[Dreamacro]

It would be nice to have the autofix feature on gci. it's really useful

[SVilgelm]

Yeah, this was the main feature of the gci, now I have to revert golangci-linter to v1.44.0

[ldez]

We (the golangci-lint team) are not responsible for changes in the linters.

Autofix support can be restored in several ways, I'll try to see what I can do but the gci changes are deep, I don't promise anything.

[SVilgelm]

there are a lot of questions to gci, the auto fix is just one of them. The error messages are completely unclear, like expected \t, but got \n. I will open issues on gci repo.

About restoring, I see that gci can do it if we use gci cli, probably we should talk with the @daixiang0

[SVilgelm]

@ldez I see that the logic to prepare a diff was removed in that PR

err = differ.Diff(&diff, bytes.NewReader(source), bytes.NewReader(result))
if err != nil {
	return nil, fmt.Errorf("can't get gci diff output: %v", err)
}

I remember I had to implement it because the gci did not support analyzer at that time. Can we restore it?

[ldez]

Can we restore it?

no because gci is now an analyzer, we don't have like goimports/gofmt a "diffable" output