From b138697ad81cffe5bc81ad8029e0264a0d382a1e Mon Sep 17 00:00:00 2001 From: Melvin Laplanche Date: Sun, 20 Sep 2020 18:42:30 -0700 Subject: [PATCH 1/2] ci: prevent windows and macos to be marked as passing upon failure --- .github/workflows/pr.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c4b6fd398f16..2c7b84661840 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -44,7 +44,6 @@ jobs: go-version: 1.15 # test only the latest go version to speed up CI - name: Run tests run: make.exe test - continue-on-error: true tests-on-macos: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: macos-latest @@ -56,7 +55,6 @@ jobs: go-version: 1.15 # test only the latest go version to speed up CI - name: Run tests run: make test - continue-on-error: true tests-on-unix: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: ubuntu-latest From f92895f78c6dd21cfcaa8344a34239c5d76f477b Mon Sep 17 00:00:00 2001 From: Melvin Laplanche Date: Sun, 20 Sep 2020 18:55:17 -0700 Subject: [PATCH 2/2] put the option back on windows --- .github/workflows/pr.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2c7b84661840..484394b0dc2d 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -44,6 +44,7 @@ jobs: go-version: 1.15 # test only the latest go version to speed up CI - name: Run tests run: make.exe test + continue-on-error: true tests-on-macos: needs: golangci-lint # run after golangci-lint action to not produce duplicated errors runs-on: macos-latest