Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: payment when debit note coming after invoice #2940

Closed
golmek opened this issue Dec 8, 2023 · 4 comments · Fixed by #2962
Closed

Fix: payment when debit note coming after invoice #2940

golmek opened this issue Dec 8, 2023 · 4 comments · Fixed by #2962
Assignees
@scx1332
Labels
bug Something isn't working

Comments

@golmek
Copy link
Contributor

golmek commented Dec 8, 2023 •
edited
Loading

Image

Acceptance Criteria:

  • yagna does not process any payment related to an agreement for which the invoice was already calculated and scheduled for payment.

Additional Information:
@golmek
Copy link
Contributor Author

golmek commented Dec 18, 2023 •
edited
Loading

To be done in 14.1.
Blocked - needs revisiting

@golmek golmek changed the title Fix: payment when debit note coming after invoide Fix: payment when debit note coming after invoice Jan 3, 2024
@nieznanysprawiciel nieznanysprawiciel added the bug Something isn't working label Jan 3, 2024
@golmek
Copy link
Contributor Author

golmek commented Jan 3, 2024

@scx1332 - talk with Jacek to reproduce bug

@golmek
Copy link
Contributor Author

golmek commented Jan 4, 2024

TODO:
Build + Test

@kamirr kamirr linked a pull request Jan 4, 2024 that will close this issue
Fix double spending by additional check when receiving debit note #2962
Merged
@golmek
Copy link
Contributor Author

golmek commented Jan 5, 2024

To be closed today - @scx1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scx1332 scx1332

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix double spending by additional check when receiving debit note golemfactory/yagna
3 participants
@nieznanysprawiciel @scx1332 @golmek