Faster graceful daemon cancels #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the spawn task is waiting on a daemon actor it is likely in `await proc.wait()`, however, if the actor nursery is subsequently cancelled this checkpoint will be abandoned and the hard proc reaping sequence will execute which results in a up to 3 second wait before a "hard" system signal is sent to the child. Ideally such a cancelled-during-daemon-actor-wait condition is instead handled by first trying to cancel the remote actor using `Portal.cancel_actor()` (a "graceful" remote cancel request) which should (presuming normal runtime operation) result in an immediate collection of the process after normal actor (remotely triggered) runtime cancellation.
goodboy
force-pushed
the
faster_daemon_cancels
branch
from
ae4e7c7 to
7eb465a
Compare
|
ugh, frickin windows. |
goodboy
added
bug
goodboy
force-pushed
the
faster_daemon_cancels
branch
from
f2bf1d6 to
16a3321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was kind of a bug where if the soft wait (
await .proc.wait()) in the reaper task was cancelled we could fail over to the hard reap sequence which has a timeout of 3s (currently) before system signalling the subproc.This adds a test to catch that slower then necessary reaping delay and adds the fix where if the graceful daemon actor proc wait is cancelled we relay that cancellation to the actor via
Portal.cancel_actor()which should result in a much faster graceful teardown.I'm pretty sure I already worked through some of this in the (now history mangled) zombie lord branch..