Debug flag per actor #271
Merged
Debug flag per actor #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out recent improvements have made the debugger too good so we need to just terminate the continue loop in this test when we finally see the "spawn error" crash out because the breakpoint forever case will literally, continue forever XD
|
@guilledk besides nooz, if CI is clean, i think this is ready to land as well. |
If we make it too fast a nursery with debug mode children can cancel too fast and causes some test failures. It's likely not a huge deal anyway since the purpose of this poll/check is for human interaction and the current delay isn't really that noticeable. Decrease log levels in the debug module to avoid console noise when in use. Toss in some more detailed comments around the new debugger lock points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft try at allowing per-actor debug mode control(s).
Also some fixes to the test suite to actually use correct log level settings as well as some logic to use
PDBlevel logging by default wheneverdebug_mode=Trueis set.This this probably could use some tests?