This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
[WIP / PARKED] Ecmascript2020 support #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhass
commented
Apr 20, 2020
| @@ -1,5 +1,9 @@ | |||
| module.exports = { | |||
| extends: ['airbnb-base'], | |||
| parser: "babel-eslint", | |||
There was a problem hiding this comment.
Had to switch to babel-eslint because eslints default parser doesn't support all ECMAScript2020 features. eslint/js#441
Some packages using eslint-config-nebenan-base don't use babel at all (like
gracefultools, domain-checker, contentful-sync ...). Tried to update to newest version in gracefultools and it worked right out the box because babel-eslint lists babel as it's own dependency (will change it later versions).
babel-eslint v11.x.x (we're at 10.x.x) expects a valid babel configuration file to work.
I think in summary, I would wait a bit for espree to finish their es2020 support.
There was a problem hiding this comment.
park this and let's wait a bit, it's probably too early to have this feature
peterhass
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.