Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Sdk Version in litert-gpu-api and causing to add WRITE_EXTERNAL_STORAGE, READ_PHONE_STATE, READ_EXTERNAL_STORAGE #562

Open
unisons opened this issue Jan 23, 2025 · 1 comment
Assignees

Comments

@unisons
Copy link

unisons commented Jan 23, 2025

litert-gpu-api doesn't have min sdk version in their aar's AndroidManifest.xml
https://maven.google.com/web/index.html?q=com.google.ai.edge.litert#com.google.ai.edge.litert:litert-gpu-api:1.0.1

It is causing add some unnecesary permission to the app.

uses-permission#android.permission.WRITE_EXTERNAL_STORAGE
IMPLIED from xxxx/src/main/AndroidManifest.xml:2:1-48:12 reason: org.tensorflow.lite.gpu.api has a targetSdkVersion < 4
uses-permission#android.permission.READ_PHONE_STATE
IMPLIED from xxxx/src/main/AndroidManifest.xml:2:1-48:12 reason: org.tensorflow.lite.gpu.api has a targetSdkVersion < 4
uses-permission#android.permission.READ_EXTERNAL_STORAGE
IMPLIED from xxxx/src/main/AndroidManifest.xml:2:1-48:12 reason: org.tensorflow.lite.gpu.api requested WRITE_EXTERNAL_STORAGE

There are some reporting the similar issue causing this issue.

aws-amplify/aws-sdk-android#380
https://stackoverflow.com/questions/49551801/manifest-merger-showing-implied-permissions-why
google/dagger#1864

Please register new version having the min sdk version definition in their xml.

@gaikwadrahul8
Copy link
Contributor

gaikwadrahul8 commented Jan 23, 2025

Hi, @unisons
Thank you for bringing this issue to our attention, We'll discuss this issue with relevant team to update minSdkVersion in their aar's AndroidManifest.xml for litert-gpu-api and will update you. Thank you for your understanding and cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants