Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirPathEngine should use existing ValidationSupport instead of init again #1173

Closed
maimoonak opened this issue Feb 15, 2022 · 3 comments
Closed
Assignees
Labels
effort:xsmall Extra small effort - 1 day P1 High priority issue

Comments

@maimoonak
Copy link
Collaborator

Describe the Issue

The line where we are generating FhirPathEngine creates a new instance of DefaultProfileValidationSupport which occupies more than 17MB. If this is init into app anywhere again it keep multiplying and causes a performance lag. The method getValidation context into FhirContext does it automatically hence this should use validationSupport from FhirContext.

Impact on app.
Around 500MB performance impact was noticed in profiling with doing this.

Before
Screenshot from 2022-02-05 01-35-38

After
Screenshot from 2022-02-14 21-32-39

Would you like to work on the issue?

yes

@jingtang10
Copy link
Collaborator

@maimoonak do you have a proposed fix for this?

@maimoonak
Copy link
Collaborator Author

Done in #1328

@Tarun-Bhardwaj
Copy link

Closing the issue as per discussion with Maimoona.

Repository owner moved this from Backlog to Complete in Android FHIR SDK Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:xsmall Extra small effort - 1 day P1 High priority issue
Projects
Status: Complete
Development

No branches or pull requests

3 participants