Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goog.dom.createDom(..) and .setProperties(..) usages #1231

Closed
AnmAtAnm opened this issue Jul 19, 2017 · 1 comment
Closed

Remove goog.dom.createDom(..) and .setProperties(..) usages #1231

AnmAtAnm opened this issue Jul 19, 2017 · 1 comment
Labels
low priority type: cleanup

Comments

@AnmAtAnm
Copy link
Contributor

goog.dom.createDom(..) API implies it can set the attributes as its second parameter. It calls down to goog.dom.setProperties(..) to do this. setProperties() attempts direct some assignments to element.setAttribute(name, value) and others element[name] = value based on an incomplete goog.dom.DIRECT_ATTRIBUTE_MAP_ attribute name list.

DOM APIs should be stable for the functionality. TODO: define an alternative utility function.
@samelhusseini
Copy link
Contributor

This is done. I don't see any references in the codebase to createDom or setProperties.

@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnmAtAnm @samelhusseini