Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldInput on Win10: Overlay editor does not disappear when the user scrolls #1685

Closed
valfis86 opened this issue Mar 2, 2018 · 4 comments
Closed
Labels
component: browser component: fields issue: bug Describes why the code or behaviour is wrong

Comments

@valfis86
Copy link

valfis86 commented Mar 2, 2018

Problem statement

The FieldInput editor overlay does not disappear when the user interacts with the scrollbars ("inbuild scrollbars"?). Further, the overlay does not scroll with the workspace, leaving it disconnected.

grafik

Expected Behavior

The overlay should disappear as soon as the user scrolls or interacts with the scrollbar.

Actual Behavior

The editor overlay remains visible and does not scroll with the workspace.

Steps to Reproduce

Click into a textfield of a block (e.g. the number block) opens a small overlay to edit the current value. This overlay behaves incorrect if the blockly workspace is scrolled using the inbuild scrollbars. When scrolling the workspace the corresponding block changes its position as expected, but the overlay doesn't.

Operating System and Browser

Tested with the february release of blockly on a Windows 10 machine with Firefox 58 and Chrome 64.

@AnmAtAnm AnmAtAnm added issue: bug Describes why the code or behaviour is wrong affects: master labels Mar 2, 2018
@AnmAtAnm
Copy link
Contributor

AnmAtAnm commented Mar 2, 2018

Expected Behavior

The overlay should change its position when the workspace is scrolled. When navigating away from the page where the blockly workspace is shown all overlays should dissapear.

I believe the overlay should disappear as soon as the user scrolls or interacts with the scrollbar.

Also, Think there are two bugs here. The first is the overlay behavior when scrolling. The second bug is regarding field size calculation when loading some fields in some situations.

On Mac/Chrome, the overlay behaves correctly (disappears) when scrolled. I was able to reproduce the developer tools / field size error on my Mac.

@AnmAtAnm AnmAtAnm changed the title Strange behavior of the overlay to edit values FieldInput on Win10: Overlay editor does not disappear when the user scrolls Mar 5, 2018
@AnmAtAnm
Copy link
Contributor

AnmAtAnm commented Mar 5, 2018

I've split out the sizing issue to #1688, and rewrote the text above to describe only the scrolling issue.

@RoboErikG
Copy link
Contributor

@rachel-fenichel to repro

@samelhusseini
Copy link
Contributor

samelhusseini commented Mar 5, 2020

Tested on v3.20200123.1 and this no longer repros. Tested on Windows 10 with IE11 and Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: browser component: fields issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

5 participants