Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo is broken with Ctrl + Z #2765

Closed
samelhusseini opened this issue Aug 1, 2019 · 1 comment
Closed

Undo is broken with Ctrl + Z #2765

samelhusseini opened this issue Aug 1, 2019 · 1 comment
Assignees
@alschmiedt
Labels
issue: bug Describes why the code or behaviour is wrong type: regression

Comments

@samelhusseini
Copy link
Contributor

Describe the bug

Undo'ing with CTRL + Z yields an error and doesn't undo, regardless when you call it.

To Reproduce

Steps to reproduce the behavior:

  1. Open the playground
  2. Make a few changes
  3. Press Ctrl + Z

Expected behavior

Undo the last change

Screenshots

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chrome

Stacktrace

Screen Shot 2019-08-01 at 8 42 55 AM

Additional context

Checked master, only affects develop.

It appears related to this change #2710 (review)
@samelhusseini samelhusseini added issue: bug Describes why the code or behaviour is wrong affects: develop issue: triage Issues awaiting triage by a Blockly team member type: regression and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 1, 2019
@alschmiedt alschmiedt self-assigned this Aug 1, 2019
@alschmiedt
Copy link
Contributor

Fixed with #2766

@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alschmiedt alschmiedt

Labels
issue: bug Describes why the code or behaviour is wrong type: regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samelhusseini @alschmiedt