Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks with outputs misaligned in flyout #2828

Closed
rachel-fenichel opened this issue Aug 14, 2019 · 3 comments
Closed

Blocks with outputs misaligned in flyout #2828

rachel-fenichel opened this issue Aug 14, 2019 · 3 comments
Assignees
@moniika
Labels
component: toolbox/flyout issue: bug Describes why the code or behaviour is wrong type: cleanup type: regression
Milestone
2019_q3_release

Comments

@rachel-fenichel
Copy link
Collaborator

Describe the bug
Blocks with output tabs are supposed to be moved left so that the blocks align based on the visible "left edge" of the block. New rendering messed this up.

image

Expected behavior

image

Additional context

There's a question here about whether I should offset the block by the connection width or by some startX value that can be independent from the connection width.

Something similar holds true for hats.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Aug 14, 2019
@RoboErikG
Copy link
Contributor

#2800 is related to your comment about hats.

@rachel-fenichel
Copy link
Collaborator Author

#2800 is fixed by my current code, but I don't want to close it until I finish this up.

@RoboErikG RoboErikG added component: toolbox/flyout type: cleanup type: regression and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 15, 2019
@RoboErikG RoboErikG added this to the 2019_q3_release milestone Aug 15, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Aug 21, 2019
Closed
@moniika moniika mentioned this issue Sep 11, 2019
Merged
3 tasks
@moniika
Copy link
Contributor

moniika commented Sep 13, 2019

Fixed

@moniika moniika closed this as completed Sep 13, 2019
@rachel-fenichel rachel-fenichel mentioned this issue Oct 7, 2019
Merged
@moniika moniika self-assigned this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moniika moniika

Labels
component: toolbox/flyout issue: bug Describes why the code or behaviour is wrong type: cleanup type: regression
Projects
None yet
Milestone
2019_q3_release
Development

No branches or pull requests
3 participants
@moniika @RoboErikG @rachel-fenichel