Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign (ES6) in codebase #3153

Closed
3 tasks
NeilFraser opened this issue Oct 4, 2019 · 4 comments
Closed
3 tasks

Object.assign (ES6) in codebase #3153

NeilFraser opened this issue Oct 4, 2019 · 4 comments
Assignees
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@NeilFraser
Copy link
Contributor

Object.assign does not exist in any version of IE (according to MDN).
The following instances exist:

There are also three more in /package, but I don't know if they matter.

@NeilFraser NeilFraser added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Oct 4, 2019
@rachel-fenichel
Copy link
Collaborator

@alschmiedt for the ones in keyboard nav

@BeksOmega for the one in the turtle demo

I think the ones in /package just derive from the ones in core and demos.

@rachel-fenichel rachel-fenichel added this to the 2019_q3_release milestone Oct 4, 2019
@rachel-fenichel rachel-fenichel removed the issue: triage Issues awaiting triage by a Blockly team member label Oct 4, 2019
@samelhusseini
Copy link
Contributor

The ones in package are used by the npm package. I’ll take a look at those. I remember testing IE with the npm package, so I wonder why that wasn’t caught.

@samelhusseini
Copy link
Contributor

Turns out each framework patches in a polyfill. Except for our UMD sample, which is broken in IE. Will fix.

@samelhusseini
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

4 participants