Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad colour in deuteranopia theme #3372

Closed
rachel-fenichel opened this issue Oct 31, 2019 · 1 comment
Closed

Bad colour in deuteranopia theme #3372

rachel-fenichel opened this issue Oct 31, 2019 · 1 comment
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@rachel-fenichel
Copy link
Collaborator

https://github.com/google/blockly/blob/develop/core/theme/deuteranopia.js#L37

"colour_blocks": {
"colourPrimary": "#f2a72c",
"colourSecondary": "#f1c17",
"colourTertiary": "#da921c"
},

New style code is validating styles and found this error. I'm making it #f1c170 so that the playground doesn't have an error, but @alschmiedt to get the colour right.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Oct 31, 2019
@alschmiedt alschmiedt mentioned this issue Oct 31, 2019
Merged
3 tasks
@alschmiedt
Copy link
Contributor

Fixed.

@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moniika @rachel-fenichel @alschmiedt