Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zelos: Reporter block with statement input #3676

Closed
rachel-fenichel opened this issue Jan 31, 2020 · 4 comments
Closed

Zelos: Reporter block with statement input #3676

rachel-fenichel opened this issue Jan 31, 2020 · 4 comments
Assignees
Labels
component: rendering issue: bug Describes why the code or behaviour is wrong

Comments

@rachel-fenichel
Copy link
Collaborator

What it looks like in Zelos:
blockError

What it looks like in Geras:
image

What it should look like:
I'm not sure. This is the function definition, not the call. On the other hand, making this just get taller and taller means adding more dead space in the horizontal direction, which I don't like.

@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Jan 31, 2020
@Navaneethan-B
Copy link

I'm facing this issue in the new Zelos rendering.

@moniika moniika modified the milestones: Icebox, Needs discussion Feb 3, 2020
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Feb 3, 2020
@samelhusseini
Copy link
Contributor

I think for this sort of block (used for things like Promises), we should borrow a design choice from SNAP and only render the left side of the connection shape like so:

Screen Shot 2020-02-06 at 5 12 14 PM

@samelhusseini
Copy link
Contributor

So it would look something like this:

Screen Shot 2020-02-06 at 5 41 31 PM

@samelhusseini
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rendering issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

4 participants