Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up typescript compilation #5892

Closed
3 of 4 tasks
rachel-fenichel opened this issue Jan 21, 2022 · 3 comments · Fixed by #6220
Closed
3 of 4 tasks

Set up typescript compilation #5892

rachel-fenichel opened this issue Jan 21, 2022 · 3 comments · Fixed by #6220
Assignees
@cpcallen
Labels
internal External contributions not accepted

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Jan 21, 2022 •
edited by cpcallen
Loading

Is your feature request related to a problem? Please describe.

Part of #5857.

Describe the solution you'd like

  • Add a tsconfig.json.
  • Wire the typescript compiler to output into the build directory such that the closure compiler picks up the correct files.
  • Add gulp tasks and scripts in package.json to run the ts compiler and then the closure compiler.
  • Add gulp tasks and scripts in package.json to clean up generated files when needed.
@rachel-fenichel rachel-fenichel added the issue: triage Issues awaiting triage by a Blockly team member label Jan 21, 2022
This was referenced Jan 21, 2022
Merged
Closed
@alschmiedt alschmiedt added internal External contributions not accepted and removed internal External contributions not accepted issue: triage Issues awaiting triage by a Blockly team member labels Jan 25, 2022
This was referenced Jun 10, 2022
Merged
Merged
Merged
@cpcallen
Copy link
Contributor

I think that this being marked "internal" is preventing me from adding as the linked issue for PR #6220.

@cpcallen
Copy link
Contributor

I think that this being marked "internal" is preventing me from adding as the linked issue for PR #6220.

Maybe that is true but I have less confidence in this assertion, as marking the PR also as internal does not solve the problem.

@BeksOmega BeksOmega linked a pull request Jun 16, 2022 that will close this issue
feat(build): Support TypeScript in core/ #6220
Merged
4 tasks
@cpcallen
Copy link
Contributor

This is now basically complete, but I will leave open in case we decide that we do in fact want to do some post-tsc cleanup of the generated .js files (in particular, for file extensions on the imports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcallen cpcallen

Labels
internal External contributions not accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(build): Support TypeScript in core/ cpcallen/blockly
3 participants
@cpcallen @rachel-fenichel @alschmiedt