-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workspace drag surface and block drag surface #6160
Comments
This was referenced Jul 23, 2022
4 tasks
I'm going to reopen this because the removal was reverted due to it being a breaking change, but we still want to remove it in the future. Note: we're not going to add deprecation warnings b/c we use the surfaces in core, and spamming developers with warnings they can't turn off is not nice. |
1 task
Note: We need to fix the scroll-options plugin when we release this as well. |
Related to: google/blockly-samples#1664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
With the drag surface (~2-5 FPS) on b92cbd3:

Without the drag surface (~10 FPS) b92cbd3:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Ideally we wouldn't drop frames while dragging. Unfortunately most of the costs of dragging occur in the SVG engine, which we don't have a ton of control over.
Additional context
I have been able to make this a lot faster by changing things from using
setAttribute
to using<element>.style
. This lets the browser use its CSS optimizations.On https://github.com/BeksOmega/blockly/tree/perf/ws-drag (~30 FPS):
But that branch needs a lot of cleanup. Eg this does not work in IE, because IE does not support CSS transforms on SVG elements. So we need some utils that will handle setting SVG locations in a generalized way.
The text was updated successfully, but these errors were encountered: