fix(build): Fix sourcemaps #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get sourcemaps working again. - The change in tsconfig.json is sufficient to get functional, per-.ts-file sourcemaps in build/src/** that work in uncompiled mode (i.e. in the playground / tests). - No further changes are required for these to be ingested by gulp + Closure Compiler; the resulting files - build/*_compressed.js.map - now point at files in core/, blocks/, etc. This works correctly when packaged and also when doing local testing in compiled mode of the checked-in build products (i.e., after they are copied to the repository root.) - In order to get sourcemaps to work for local testing in compiled mode of the build products directly from build/, buildCompile now creates symlinks from build/ to core/, blocks/ and generators/.
maribethb
reviewed
Aug 16, 2022
Apparently I made this change locally and thought I had committed it and force-pushed _before_ opening the PR, but it appears I forgot to git add the change before the commit --amend / push --force sequence. Oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #5857.
Proposed Changes
Enable
sourceMapintsconfig.json. This alone is suffiicient to get functional, per-.ts-file sourcemaps inbuild/src/**that work in uncompiled mode (i.e. in the playground / tests). Moreover, no further changes are required for these to be ingested by gulp + Closure Compiler; the resulting sourcemaps—build/*_compressed.js.map—now correctly point at files in core/, blocks/, etc. This works when packaged and also when doing local testing in compiled mode of the checked-in build products (i.e., after they are copied to the repository root bycheckinBuilt).In order to get sourcemaps to work for local testing in compiled mode of the build products directly from
build/, modifybuildCompiledso that it creates symlinks inbuild/tocore/,blocks/andgenerators/.Behaviour Before Change
.jsfiles inbuild/src/.Behaviour After Change
.tsfiles incore/,blocks/andgenerators/.Reason for Changes
Sourcemaps are more useful if they point at the original sources.
Test Coverage
No manual testing changes anticipated.
Documentation
No documentation changes expected.