Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check why core/ is included in blockly npm package #6724

Closed
cpcallen opened this issue Dec 24, 2022 · 1 comment
Closed

Check why core/ is included in blockly npm package #6724

cpcallen opened this issue Dec 24, 2022 · 1 comment
Assignees

Comments

@cpcallen
Copy link
Contributor

Describe the bug

While debugging test failures in google/blockly-samples#1452 I noticed that the blockly npm package v9.2.0 contains all of core/**/*.ts, which is unexpected as I thought build_tasks.js had been modified so that the only source code included in the package was in the form of sourcemaps.

I should investigate to see if this is a regression, an error on my part in the previous changes, a deliberate reversion of the previous change (and if so for what reason), or if these files continue to be included for some good reason I was aware of at the time but no longer recall.

@cpcallen
Copy link
Contributor Author

It turns out that (at least as of now, in develop) the only files in the core/ directory of the package (i.e., in dist/core/ after running npm run package) are .d.ts files. So we are not shipping our TypeScript source code (except for the copy embedded in the .js.map files, as intended).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant